Skip to content

Added unset state for boolean traits #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

kamathprasad9
Copy link
Collaborator

@kamathprasad9 kamathprasad9 commented May 14, 2025

Description

Closes #201

Change Type

  • ADDITION (non-breaking change that adds functionality)
  • CHANGE (fix or feature that alters existing functionality)
  • FIX (non-breaking change that resolves an issue)
  • OTHER (use only for changes like tooling, build system, CI, docs, etc.)

Release Note

Added unset option to boolean traits

Release Type

  • MAJOR
  • MINOR
  • WAIT (No immediate release, but the changelog will be still be updated if there is a release note.)

@kamathprasad9 kamathprasad9 requested review from trife and chaneylc May 14, 2025 15:51
Copy link
Member

@trife trife left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Unset should not save a value
  • Delete should move the switch to Unset
  • Modify Default value in trait creator to be radio buttons
  • In Collect, True is always being displayed as an edited value (italics) even when it has been selected

@trife trife marked this pull request as draft June 10, 2025 19:49
@kamathprasad9 kamathprasad9 requested a review from trife July 14, 2025 18:55
@kamathprasad9 kamathprasad9 marked this pull request as ready for review July 14, 2025 20:43
@kamathprasad9 kamathprasad9 force-pushed the unset-option-boolean branch from 833974f to 389af11 Compare July 14, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TRAIT] Add unset option to Boolean trait creation and layout
2 participants