Set a pleasant-looking name for SMS 2FA #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@reefdog @slifty @hminsky2002 I don't mean all y'all should review but whoever feels like it is welcome. |
slifty
approved these changes
Mar 13, 2024
...loak-theme/src/main/resources/theme/pdc-keycloak-theme/login/messages/messages_en.properties
Outdated
Show resolved
Hide resolved
|
@slifty FWIW I admit that I gave up on trying this in my local Keycloak and relied on the test environment to try this change. |
When the SMS second-factor authentication provider is shown in a list, this commit makes the name look nicer, at least in English. Issue #19
bickelj
force-pushed
the
pleasant-name-for-sms
branch
from
29ea538 to
54eab58
Compare
|
As is our custom, I will carry the approval to the next commit given that we trust one another to resolve the given issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the SMS second-factor authentication provider is shown in a list, this commit makes the name look nicer, at least in English.
Issue #19