Customizable disguised target evaluation behaviour in new ScriptType attack actions #1169

FS-21 · 2023-10-04T15:12:05Z

By default, any unit with DetectDisguise=yes seeking targets via new attack team missions introduced in Phobos always detects the disguised units (100% probability). The probability to detect a disguised object now can be customized.
DetectDisguise.Percent values represent the probabilities in hard, medium & easy difficulty, in that order.

In rulesmd.ini:
[SOMETECHNO] ; TechnoType
DetectDisguise.Percent=1.0, 1.0, 1.0 ; float, percents or absolute

Customizable disguised target evaluation behaviour in new ScriptType attack actions. - By default, any unit with `DetectDisguise=yes` seeking targets via new [attack team missions introduced in Phobos](AI-Scripting-and-Mapping.md#10000-10049-attack-actions) always detects the disguised units. The probability to detect a disguised object now can be customized. - `DetectDisguise.Percent` values represent the probabilities in hard, medium & easy difficulty, in that order. In rulesmd.ini: [SOMETECHNO] ; TechnoType DetectDisguise.Percent=1.0, 1.0, 1.0 ; float, percents or absolute

FS-21 · 2023-10-04T15:13:57Z

Similar behaviour of the YR tag DisabledDisguiseDetectionPercent

From rulesmd.ini comments:

DisabledDisguiseDetectionPercent=25,20,15
;15,5,2 ;gs h,m,e Damn I love this section. This is the percent chance that an individual unit will detect a Mirage Tank who is fake-blinking (from Firing). This is per unit, so even a lowish number is near automatic when the computer has 10 guys nearby

So 6 units in a AI team capable to detect disguised units with the new DetectDisguise.Percent means that the disguised unit will be evaluated 6 times.

github-actions · 2023-10-04T15:19:17Z

Nightly build for this pull request:

compiled-dll-ae96d744aefdc5845b96ec9ced531773dc4ce3e0.zip
These artifacts will expire in 90 days and will not be available for download after that time.

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

Otamaa · 2023-10-04T16:30:21Z

src/Ext/TechnoType/Body.h

@@ -182,6 +182,8 @@ class TechnoTypeExt
 		Nullable<Leptons> SpawnDistanceFromTarget;
 		Nullable<int> SpawnHeight;

+		ValueableVector<double> DetectDisguise_Percent;


it is only use based on AIDifficulty right ?
mean it is only require 3 items at max , please use PartialVector3D instead of ValueableVector.

Otamaa · 2023-10-04T16:32:27Z

src/Ext/Script/Mission.Attack.cpp

@@ -399,7 +413,7 @@ void ScriptExt::Mission_Attack(TeamClass* pTeam, bool repeatAction = true, int c
 	}
 }

-TechnoClass* ScriptExt::GreatestThreat(TechnoClass* pTechno, int method, int calcThreatMode = 0, HouseClass* onlyTargetThisHouseEnemy = nullptr, int attackAITargetType = -1, int idxAITargetTypeItem = -1, bool agentMode = false)
+TechnoClass* ScriptExt::GreatestThreat(TechnoClass* pTechno, int method, int calcThreatMode = 0, HouseClass* onlyTargetThisHouseEnemy = nullptr, int attackAITargetType = -1, int idxAITargetTypeItem = -1, bool agentMode = false, std::vector<double> disguiseDetection = {})


Pass the value of PartialVector3D as const reference if no modification required , to avoid unnessesary copy.

Otamaa · 2023-10-04T16:33:23Z

src/Ext/Script/Mission.Attack.cpp

+					detectionValue = pTechnoData->DetectDisguise_Percent[AIDifficulty];
+
+				detectionValue = detectionValue > 0.0 ? detectionValue : 1.0;
+				disguiseDetection.push_back(detectionValue);


Dont do this every time function called, fix this on INIReading moment instead.

…etect-disguises

coderabbitai · 2024-03-14T15:00:29Z

Warning

Rate Limit Exceeded

@FS-21 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 29 minutes and 28 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between eef9bc0 and fbc3035.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Otamaa requested changes Oct 4, 2023

View reviewed changes

FS-21 mentioned this pull request Dec 30, 2023

AI Script 10000-10001,10005-10006,10010-10011,10014-10015 may attack disguised infantry/units #1189

Open

5 tasks

FS-21 added 3 commits March 10, 2024 16:45

Merge remote-tracking branch 'origin/develop' into feature/ai-teams-d…

3d265ff

…etect-disguises

Merge remote-tracking branch 'origin/develop' into feature/ai-teams-d…

f42b2eb

…etect-disguises

Merge branch 'develop' into feature/ai-teams-detect-disguises

fbc3035

Merge branch 'develop' into feature/ai-teams-detect-disguises

16042b9

chaserli force-pushed the develop branch from 7a22efe to c801eb9 Compare June 9, 2024 14:18

FS-21 added 4 commits August 30, 2024 12:32

Merge branch 'develop' into feature/ai-teams-detect-disguises

1b0a658

Merge branch 'develop' into feature/ai-teams-detect-disguises

1484010

Merge branch 'develop' into feature/ai-teams-detect-disguises

950823d

Merge branch 'develop' into feature/ai-teams-detect-disguises

d8b71d5

Starkku force-pushed the develop branch from 31f2f2a to 804eadb Compare October 31, 2024 12:48

Merge branch 'develop' into feature/ai-teams-detect-disguises

e3e4d9a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Customizable disguised target evaluation behaviour in new ScriptType attack actions #1169

Customizable disguised target evaluation behaviour in new ScriptType attack actions #1169

FS-21 commented Oct 4, 2023 •

edited

Loading

FS-21 commented Oct 4, 2023 •

edited

Loading

github-actions bot commented Oct 4, 2023 •

edited

Loading

Otamaa Oct 4, 2023

Otamaa Oct 4, 2023

Otamaa Oct 4, 2023

coderabbitai bot commented Mar 14, 2024

Rate Limit Exceeded

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

Customizable disguised target evaluation behaviour in new ScriptType attack actions #1169

Are you sure you want to change the base?

Customizable disguised target evaluation behaviour in new ScriptType attack actions #1169

Conversation

FS-21 commented Oct 4, 2023 • edited Loading

FS-21 commented Oct 4, 2023 • edited Loading

github-actions bot commented Oct 4, 2023 • edited Loading

Otamaa Oct 4, 2023

Choose a reason for hiding this comment

Otamaa Oct 4, 2023

Choose a reason for hiding this comment

Otamaa Oct 4, 2023

Choose a reason for hiding this comment

coderabbitai bot commented Mar 14, 2024

Rate Limit Exceeded

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

FS-21 commented Oct 4, 2023 •

edited

Loading

FS-21 commented Oct 4, 2023 •

edited

Loading

github-actions bot commented Oct 4, 2023 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)