Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light effect customizations #1205

Merged

Conversation

Starkku
Copy link
Contributor

@Starkku Starkku commented Feb 13, 2024

Combat light customizations

  • You can now set minimum detail level at which combat light effects are shown by setting [AudioVisual] -> CombatLightDetailLevel or CombatLightDetailLevel on Warhead, latter defaults to former.
  • You can now set a percentage chance a combat light effect is shown on Warhead impact by setting CombatLightChance.

In rulesmd.ini:

[AudioVisual]
CombatLightDetailLevel=0                     ; integer

[SOMEWARHEAD]                                ; WarheadType
CombatLightDetailLevel=                      ; integer
CombatLightChance=1.0                        ; floating point value, percents or absolute (0.0-1.0)

Light flash effect toggling

  • It is possible to toggle certain light flash effects off. These light flash effects include:
    • Combat light effects (Bright=true) and everything that uses same functionality e.g Iron Curtain / Force Field impact flashes.
    • Alpha images attached to ParticleSystems or Particles that are generated through a Warhead's Particle if [AudioVisual] -> WarheadParticleAlphaImageIsLightFlash or on Warhead Particle.AlphaImageIsLightFlash is set to true, latter defaults to former.
      • Additionally these alpha images are not created if [AudioVisual]->LightFlashAlphaImageDetailLevel is higher than current detail level, regardless of the HideLightFlashEffects setting.

In rulesmd.ini:

[AudioVisual]
WarheadParticleAlphaImageIsLightFlash=false  ; boolean
LightFlashAlphaImageDetailLevel=0            ; integer

[SOMEWARHEAD]                                ; WarheadType
Particle.AlphaImageIsLightFlash=             ; boolean

In RA2MD.ini:

[Phobos]
HideLightFlashEffects=false  ; boolean

Copy link

coderabbitai bot commented Feb 13, 2024

Warning

Rate Limit Exceeded

@Starkku has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 32 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 159d5bb and fbc8ef0.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

github-actions bot commented Feb 13, 2024

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@Starkku Starkku force-pushed the feature/light-effects-toggle branch from fbc8ef0 to 75606dd Compare March 20, 2024 09:54
@Starkku Starkku force-pushed the feature/light-effects-toggle branch 2 times, most recently from b09f3a2 to 86348d4 Compare April 9, 2024 12:47
@Starkku Starkku force-pushed the feature/light-effects-toggle branch from 86348d4 to 4d23791 Compare May 2, 2024 07:14
@Starkku Starkku force-pushed the feature/light-effects-toggle branch from 4d23791 to 7656be6 Compare May 11, 2024 12:22
Copy link
Contributor

@FS-21 FS-21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no mistakes in the code style or any visible mistake.

@Starkku Starkku force-pushed the feature/light-effects-toggle branch from 7656be6 to c5b48ba Compare May 19, 2024 13:41
@Starkku Starkku force-pushed the feature/light-effects-toggle branch from c5b48ba to ff2a273 Compare June 11, 2024 14:22
@Starkku Starkku force-pushed the feature/light-effects-toggle branch from ff2a273 to c285424 Compare June 25, 2024 09:35
@Starkku Starkku force-pushed the feature/light-effects-toggle branch 2 times, most recently from 9d2e3fd to cc3bb39 Compare July 11, 2024 13:50
@Starkku Starkku force-pushed the feature/light-effects-toggle branch from cc3bb39 to 5012a40 Compare August 28, 2024 20:23
@Starkku Starkku force-pushed the feature/light-effects-toggle branch from 5012a40 to 48b2d32 Compare October 9, 2024 18:33
@Starkku Starkku merged commit caf39b3 into Phobos-developers:develop Oct 9, 2024
6 checks passed
@Starkku Starkku deleted the feature/light-effects-toggle branch October 9, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants