Allow the creation of new Tiberiums #1234
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZivDero
force-pushed
the
feature/extended-tiberium
branch
from
b572954 to
8083d45
Compare
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
Metadorius
reviewed
Mar 30, 2024
src/Ext/House/Hooks.cpp
Outdated
Comment on lines
265
to
354
| { | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
Suggested change
| { | |
| return 0; | |
| } | |
| return 0; |
src/Ext/House/Hooks.cpp
Outdated
Comment on lines
279
to
368
| { | ||
| amount = static_cast<float>(lastTotalStorage - lastStorage); | ||
| } |
There was a problem hiding this comment.
Suggested change
| { | |
| amount = static_cast<float>(lastTotalStorage - lastStorage); | |
| } | |
| amount = static_cast<float>(lastTotalStorage - lastStorage); |
src/Ext/House/Hooks.cpp
Outdated
Comment on lines
287
to
376
| { | ||
| break; | ||
| } |
There was a problem hiding this comment.
Suggested change
| { | |
| break; | |
| } | |
| break; |
src/Ext/House/Hooks.cpp
Outdated
Comment on lines
299
to
388
| { | ||
| freeSpace = amount; | ||
| } |
There was a problem hiding this comment.
Suggested change
| { | |
| freeSpace = amount; | |
| } | |
| freeSpace = amount; |
src/Ext/Tiberium/Body.cpp
Outdated
Comment on lines
147
to
150
| if (auto pOverlay = TiberiumExt::ExtMap.Find(pItem)->Overlays[0]) | ||
| { | ||
| pItem->Image = pOverlay; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (auto pOverlay = TiberiumExt::ExtMap.Find(pItem)->Overlays[0]) | |
| { | |
| pItem->Image = pOverlay; | |
| } | |
| if (auto pOverlay = TiberiumExt::ExtMap.Find(pItem)->Overlays[0]) | |
| pItem->Image = pOverlay; |
Comment on lines
20
to
22
| { | ||
| total += Tiberiums[i]; | ||
| } |
There was a problem hiding this comment.
Suggested change
| { | |
| total += Tiberiums[i]; | |
| } | |
| total += Tiberiums[i]; |
Comment on lines
62
to
64
| { | ||
| storageClass->Tiberiums[i] = Tiberiums[i] + that.Tiberiums[i]; | ||
| } |
There was a problem hiding this comment.
Suggested change
| { | |
| storageClass->Tiberiums[i] = Tiberiums[i] + that.Tiberiums[i]; | |
| } | |
| storageClass->Tiberiums[i] = Tiberiums[i] + that.Tiberiums[i]; |
Comment on lines
72
to
74
| { | ||
| Tiberiums[i] += that.Tiberiums[i]; | ||
| } |
There was a problem hiding this comment.
Suggested change
| { | |
| Tiberiums[i] += that.Tiberiums[i]; | |
| } | |
| Tiberiums[i] += that.Tiberiums[i]; |
Comment on lines
83
to
85
| { | ||
| storageClass->Tiberiums[i] = Tiberiums[i] - that.Tiberiums[i]; | ||
| } |
There was a problem hiding this comment.
Suggested change
| { | |
| storageClass->Tiberiums[i] = Tiberiums[i] - that.Tiberiums[i]; | |
| } | |
| storageClass->Tiberiums[i] = Tiberiums[i] - that.Tiberiums[i]; |
Comment on lines
93
to
95
| { | ||
| Tiberiums[i] -= that.Tiberiums[i]; | ||
| } |
There was a problem hiding this comment.
Suggested change
| { | |
| Tiberiums[i] -= that.Tiberiums[i]; | |
| } | |
| Tiberiums[i] -= that.Tiberiums[i]; |
ZivDero
force-pushed
the
feature/extended-tiberium
branch
from
17fb1c1 to
098024b
Compare
Co-authored-by: Otamaa <9769329+Otamaa@users.noreply.github.com>
ZivDero
force-pushed
the
feature/extended-tiberium
branch
from
098024b to
5dcb105
Compare
ZivDero
force-pushed
the
feature/extended-tiberium
branch
from
5dcb105 to
1f3bb8d
Compare
ZivDero
force-pushed
the
feature/extended-tiberium
branch
from
63c3a8f to
b97155d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the creation of new Tiberiums.
Docs coming later.
TODO: