Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Customized] Damage multiplier for different houses #1307

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from

Conversation

CrimRecya
Copy link
Contributor

  • Warheads are now able to define the extra damage multiplier for owner house, ally houses and enemy houses. The values in warheads are default to respective [CombatDamage] -> DamageXXMultiplier, which all default to 1.0 .Note that this will not affect damage with ignore defenses.

In rulesmd.ini:

[CombatDamage]
DamageOwnerMultiplier=1.0     ; floating point value
DamageAlliesMultiplier=1.0    ; floating point value
DamageEnemiesMultiplier=1.0   ; floating point value

[SOMEWARHEAD]                 ; Warhead
DamageOwnerMultiplier=        ; floating point value
DamageAlliesMultiplier=       ; floating point value
DamageEnemiesMultiplier=      ; floating point value

Copy link
Contributor

@Coronia Coronia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since Phobos already has an extra warhead logic, suggest to rename this one a bit. 'damage multiplier for different houses' perhaps

src/Ext/Techno/Hooks.Shield.cpp Outdated Show resolved Hide resolved
@CrimRecya CrimRecya changed the title Extra warhead multiplier for different houses Damage multiplier for different houses Aug 14, 2024
Copy link
Contributor

@Coronia Coronia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think it'd better not to be blocked by IgnoreDefenses in order to be consistent with other firepower multipliers. The shield part can be kept as it was

src/Ext/Techno/Hooks.Shield.cpp Outdated Show resolved Hide resolved
docs/New-or-Enhanced-Logics.md Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Sep 18, 2024

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@CrimRecya CrimRecya changed the title Damage multiplier for different houses [Customized] Damage multiplier for different houses Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants