Skip to content

[Customized] Delay automatic attack on the controlled unit #1474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 22, 2025

Conversation

CrimRecya
Copy link
Contributor

@CrimRecya CrimRecya commented Dec 28, 2024

  • Now you can make the techno that has just been mind controlled not be automatically attacked by its original friendly forces for a period of time defined by MindControl.ThreatDelay on the mind control warhead, default to [General]->MindControl.ThreatDelay. This will not affect the manual selection of attacks and is useless with permanent mind control.

In rulesmd.ini:

[General]
MindControl.ThreatDelay=0     ; integer, game frames

[SOMEWARHEAD]                 ; Warhead
MindControl.ThreatDelay=      ; integer, game frames

Copy link

github-actions bot commented Dec 28, 2024

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@Starkku
Copy link
Contributor

Starkku commented Jan 14, 2025

Is there any impact on performance here given that 0x6F7EA2 is at code that is called very often?

@CrimRecya
Copy link
Contributor Author

Is there any impact on performance here given that 0x6F7EA2 is at code that is called very often?

Thank you for your reminding. Although I haven't found any significant frame rate changes yet, it's really not appropriate. I will hook in a relatively backward position later.

@TaranDahl
Copy link
Contributor

Tested locally. Doing good.

@Coronia Coronia added the ⚙️T1 T1 maintainer review is sufficient label Mar 21, 2025
@Coronia Coronia merged commit b75c8f0 into Phobos-developers:develop Mar 22, 2025
7 checks passed
@CrimRecya CrimRecya deleted the develop-AttackMCDelay branch April 1, 2025 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️T1 T1 maintainer review is sufficient Tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants