Refactor Fog of War round 2 #1872
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons not showing behind fog if SpySat=yes
…es drawing buildings
- Hide particles under fog for all units, not just enemies - Add exception handling to prevent cursor targeting crashes on fogged buildings - Simplify fog checks using Fog::IsFogged() for consistency
… removed Ebolt debug logging
…oveShroudOnly should still work though
…rlayTypes and TerrainTypes. still to do: objects remain on screen unchanged from fog proxy state
…rmance, and cleanup issues
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
TaranDahl
added
❓Restored feature
|
-Terrain Objects with custom palettes are using theater palette under fog 
|
|
If it really doesn't work, then forget it. Using a smoke shell combined with passive super weapon effects is also quite good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking up the closed PR #530 .
Forward ported the old PR and fixed the following from showing under fog:
Other improvements:
RemoveShroudGloballyto combat the Shroud=no issue belowBuildingType,OverlayTypeandTerrainTypeflickering/vanishing under fogRemoveShroudGlobally
I added this as a way to bypass the Shroud=no issue, it works by removing Shroud at the beginning of the game, while keeping Fog intact. How to use:
Note: this can also be enabled via CnCNet Client configuration
CnCNet Client
In your game/skirmish/multiplayerlobby config, add a GameLobbyCheckBox with:
Still to do:
Ripple.RadiusProduceCashDisplayRefinerySmokeParticleSystemcreated by SlavedInfantryTypesstill shows under fogSevere issues:
RemoveShroudGlobally)Future QOL:
Shroud=noinstead ofRemoveShroudGlobally=yes, a pro will need to look into it.quick.fow.mp4