Fast access extended to structure #1874
Conversation
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
There was a problem hiding this comment.
It would be better to add global toggles to control these behaviors for buildings, in case modders only want vehicles to load and unload quickly
NoQueueUpToEnter.Buildings=; default to NoQueueUpToEnter
NoQueueUpToUnload.Buildings=; default to NoQueueUpToUnload
Fly-Star-him
changed the title
|
|
||
| if (pObject->WhatAmI() == AbstractType::Building) | ||
| { | ||
| const auto RulesExt = RulesExt::Global(); |
There was a problem hiding this comment.
pRulesExt and there are four same issue behind this.
| const auto pTunnel = AresHelper::CanUseAres ? | ||
| AresFunctions::GetTunnel(reinterpret_cast<void*>(pType->align_E24), pBuilding->Owner) : nullptr; |
There was a problem hiding this comment.
const auto pTunnel = AresHelper::CanUseAres
? AresFunctions::GetTunnel(reinterpret_cast<void*>(pType->align_E24), pBuilding->Owner) : nullptr;
and there is a same issue behind this.
| DEFINE_HOOK(0x44DCB1, BuildingClass_Mi_Unload_NoQueueUpToUnload, 0x7) | ||
| { | ||
| GET(BuildingClass*, pThis, EBP); | ||
|
|
||
| const auto RulesExt = RulesExt::Global(); | ||
|
|
||
| if (TechnoTypeExt::ExtMap.Find(pThis->Type)->NoQueueUpToUnload.Get( | ||
| RulesExt->NoQueueUpToUnload_Buildings.Get(RulesExt->NoQueueUpToUnload))) | ||
| { | ||
| R->EAX(0); | ||
| } | ||
|
|
||
| return 0; | ||
| } |
There was a problem hiding this comment.
It still looks like unloading one by one every frame, rather than unloading all at once.
There was a problem hiding this comment.
Because I am not yet able to handle tunnel unloading in construction.
#1475 #1602
Extend their logic to the structure.