Skip to content

Retry All failed button in Upload journal #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

zealot128
Copy link
Contributor

@zealot128 zealot128 commented May 21, 2016

I've added a button to initiate a new upload of all failed media.

  • Hovering button at the bottom (is there a better place?)
  • Alert box, just copypaste from manual upload
  • Missing fr/cz translations

As now, this commit depends on some of the other PRs before, cherry-picking lead to some conflicts.
I might try to extract it, if it is necessary, but would rather wait until the other changes are done.

The relevant changes are in 1ec2382
screenshot_20160521-161757

@zealot128 zealot128 changed the title Retry All failed button in Upload journal (WIP) Retry All failed button in Upload journal May 31, 2016
@zealot128
Copy link
Contributor Author

I've rebased and fixed some small things. As of now, the Bucket picker commits (other PR) is still in it...
For that; I've used that for 2 weeks now and it seems to work :)

Until we have some kind of archived, I've added a small condition that only images younger than 6 months are considered anyway.

The manual still has one issue:

  • The upload is like manual, that means it is inside the Activity, not in the Service. So stopping the service won't stop the upload AFAIK. And it seems all of the 100 uploads are triggered immediately. It is not a big problem for me though, just a very small lag at the start OKhttp or Android seem to queue the requests then. Anyway, uploading works good for me (if I disable VPN here... with VPN get a lot of EndOfStream..).
    Better solution would be to somehow tell the Service to take over the upload..? but i am not quite sure on how to handle that :|
  • fr/cz translations..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant