-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/fs encode implementation #16
Open
techalchemy
wants to merge
8
commits into
PiDelport:master
Choose a base branch
from
techalchemy:bugfix/fs-encode-implementation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Bugfix/fs encode implementation #16
techalchemy
wants to merge
8
commits into
PiDelport:master
from
techalchemy:bugfix/fs-encode-implementation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Ryan <dan@danryan.co>
- Mirrors the new python 3.7 implementation - Taken from `vistir` (my other library) -> discussion over at sarugaku/vistir#54 - Fixes PiDelport#13 - Fixes PiDelport#6 (I think?) Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
==========================================
- Coverage 96.55% 88.49% -8.06%
==========================================
Files 5 5
Lines 174 226 +52
Branches 27 32 +5
==========================================
+ Hits 168 200 +32
- Misses 2 20 +18
- Partials 4 6 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix fsencode and fsdecode backports
vistir
(my other library) -> discussion over atAdd support for proper filesystem encodings sarugaku/vistir#54
surrogatepass
high bytes for testing thesurrogatepass
error handler which is implemented natively on windows as of python 3.6+>3.0,<3.6
on windows in that it relies on thesurrogatepass
handler and opts to write unicode/utf-8 rather than the native handlers