Feature: new eslint and github action CI (#5)

* feat: new eslint and github action CI

* chore: update lock file

* fix: typo on CI

* feat: update ci env

* chore: fix typo

---------

Co-authored-by: nnh53 <“nnh53.work@gmail.com”>

.editorconfig

@@ -6,7 +6,7 @@ root = true
 [*]
 indent_style = space
 indent_size = 2
-end_of_line = lf
+end_of_line = unset
 charset = utf-8
 trim_trailing_whitespace = true
 insert_final_newline = true

.env.demo

@@ -1,7 +1,9 @@
-# production
-PRODUCTION_BACKEND_URL="https://backend.onrender.com"
-VITE_PRODUCTION_BACKEND_URL="https://backend.onrender.com"
+VITE_DEVELOPEMENT_GOOGLE_OAUTH_URL = 'http://localhost:4000/oauth/google'
+VITE_PRODUCTION_GOOGLE_OAUTH_URL = 'http://rendebe/oauth/google'
 
-# development
-DEVELOPMENT_BACKEND_URL="http://localhost:3000"
-VITE_DEVELOPMENT_BACKEND_URL="http://localhost:3000"
+
+VITE_DEVELOPEMENT_FACEBOOK_OAUTH_URL = 'http://localhost:4000/oauth/facebook'
+VITE_PRODUCTION_FACEBOOK_OAUTH_URL = 'http://renderbe/oauth/facebook'
+
+VITE_PRODUCTION_BACKEND_URL = 'http://renderbe.com'
+VITE_DEVELOPMENT_BACKEND_URL = 'http://localhost:4000'

.eslintignore

@@ -1,2 +1,3 @@
 node_modules
 dist
+public

.eslintrc.json

@@ -1,12 +1,12 @@
 {
   "env": { "node": true, "browser": true },
   "$schema": "https://json.schemastore.org/eslintrc",
-  "root": true,
+  // "root": true,
   "plugins": [
     "react",
     "prettier",
     "@typescript-eslint",
-    "@stylistic",
+    // "@stylistic",
     "import",
     "promise",
     "jsx-a11y",
@@ -39,7 +39,7 @@
     "plugin:import/typescript", //eslint-plugin-import and eslint-import-resolver-typescript
 
     // eslint stylistic
-    "plugin:@stylistic/recommended-extends", //@stylistic/eslint-plugin
+    // "plugin:@stylistic/recommended-extends", //@stylistic/eslint-plugin
 
     // react
     "plugin:jsx-a11y/recommended", //eslint-plugin-jsx-a11y
@@ -50,7 +50,7 @@
     // tailwindcss
     "plugin:tailwindcss/recommended", //eslint-plugin-tailwindcss
     // prettier THIS MUST BE LAST
-    // "plugin:prettier/recommended", //eslint-PLUGIN-prettier //disable because focus on new @stylistic/eslint-plugin
+    "plugin:prettier/recommended", //eslint-PLUGIN-prettier //disable because focus on new @stylistic/eslint-plugin
     "prettier" //eslint-CONFIG-prettier (turn off eslint **rules** that conflict with prettier), turn on prettier/prettier rules
     //eslint-CONFIG-prettier is used in "check-conflict-prettier-eslint" in package.json
   ],
@@ -69,20 +69,21 @@
     "no-console": "error",
     "require-await": "error",
     "eqeqeq": "error",
+    "no-nested-ternary": "error",
 
     // eslint stylistic
-    "@stylistic/quotes": ["error", "double"],
-    "@stylistic/jsx-one-expression-per-line": "off",
-    "@stylistic/semi": ["error", "always"],
-    "@stylistic/arrow-parens": ["error", "always"],
-    "@stylistic/brace-style": ["error", "1tbs", { "allowSingleLine": true }],
-    "@stylistic/member-delimiter-style": [
-      "error",
-      {
-        "multiline": { "delimiter": "semi", "requireLast": true },
-        "singleline": { "delimiter": "semi", "requireLast": false }
-      }
-    ],
+    // "@stylistic/quotes": ["error", "double"],
+    // "@stylistic/jsx-one-expression-per-line": "off",
+    // "@stylistic/semi": ["error", "always"],
+    // "@stylistic/arrow-parens": ["error", "always"],
+    // "@stylistic/brace-style": ["error", "1tbs", { "allowSingleLine": true }],
+    // "@stylistic/member-delimiter-style": [
+    //   "error",
+    //   {
+    //     "multiline": { "delimiter": "semi", "requireLast": true },
+    //     "singleline": { "delimiter": "semi", "requireLast": false }
+    //   }
+    // ],
 
     // plugin
     "import/no-unresolved": "error", //eslint-plugin-import and eslint-import-resolver-typescript
@@ -121,13 +122,15 @@
     "react": {
       "version": "detect"
     },
-    "import/parsers": {
-      "@typescript-eslint/parser": [".ts", ".tsx"] //eslint-plugin-import and eslint-import-resolver-typescript
-    },
     "import/resolver": {
       //eslint-plugin-import and eslint-import-resolver-typescript
-      "typescript": true,
-      "node": true
+      "node": {
+        "extensions": [".js", ".jsx", ".ts", ".tsx"]
+      },
+      "typescript": {
+        "alwaysTryTypes": true,
+        "project": "./tsconfig.json"
+      }
     }
   }
 }

.github/workflows/checkPR.yml

@@ -0,0 +1,70 @@
+# Run: Check CI on PR
+name: Check CI on PR
+
+on:
+  pull_request:
+    branches: ["main"]
+
+jobs:
+  lint_PR:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Check pnpm standalone
+        uses: actions/cache@v4
+        with:
+          path: /home/runner/setup-pnpm/node_modules/.bin/pnpm
+          key: ${{ runner.os }}-pnpm-standalone
+          restore-keys: |
+            ${{ runner.os }}-pnpm-standalone
+
+      - name: Install pnpm
+        uses: pnpm/action-setup@v4
+        with:
+          version: 9
+          run_install: false
+          standalone: false
+
+      - name: Install node
+        uses: actions/setup-node@v4
+        with:
+          node-version: 20
+
+      # - name: which pnpm
+      #   shell: bash
+      #   run: |
+      #     which pnpm
+      #   env:
+      #     TEST_TEST: ${{ steps.pnpmahihi.outputs.bin_dest }}
+
+      # - name: echo echo $PNPM_HOME
+      #   shell: bash
+      #   run: |
+      #     echo $PNPM_HOME
+
+      # - name: echo pnpm store directory
+      #   shell: bash
+      #   run: |
+      #     pnpm store path
+
+      # - name: Get pnpm store directory
+      #   shell: bash
+      #   run: |
+      #     echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV
+
+      - name: Setup pnpm node_module cache
+        uses: actions/cache@v4
+        with:
+          path: /home/runner/setup-pnpm/node_modules/.bin/store/v3
+          key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
+          restore-keys: |
+            ${{ runner.os }}-pnpm-store-
+
+      - name: Install dependencies
+        run: pnpm install
+
+      - name: Lint
+        run: pnpm run prettier:check && pnpm run eslint:check-allow-warning && pnpm run check-types

.gitignore

@@ -1,24 +1,8 @@
-# Logs
-logs
-*.log
-npm-debug.log*
-yarn-debug.log*
-yarn-error.log*
-pnpm-debug.log*
-lerna-debug.log*
-
-node_modules
 dist
-dist-ssr
+node_modules
 *.local
-
-# Editor directories and files
-.vscode/*
-!.vscode/extensions.json
-.idea
+.env
+deploy
+.firebase
 .DS_Store
-*.suo
-*.ntvs*
-*.njsproj
-*.sln
-*.sw?
+.idea

.husky/pre-commit

@@ -1,2 +1,3 @@
-yarn run lint-staged
-yarn run lint
+echo "Running pre-commit hook"
+pnpm run lint-staged
+pnpm run lint

.prettierignore

@@ -4,4 +4,5 @@ coverage
 build
 dist
 node_modules
-husky
+.husky
+public