Skip to content

Commit

Permalink
Feature/new eslint config (#104)
Browse files Browse the repository at this point in the history
* fix: fixing eslint in progress

* fix: update config

* fix: completed fix new eslint config bug

* feature: optimized install pnpm github action not lint

* feat: add lint github action

* fix: husky prepare

* chore: fix typo

* fix: wrong ignore and fixed

---------

Co-authored-by: nnh53 <“nnh53.work@gmail.com”>
  • Loading branch information
nnh53 and nnh53 authored Jun 26, 2024
1 parent b332ef9 commit 23ace94
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 10 deletions.
12 changes: 3 additions & 9 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,7 @@
"jsx-a11y",
"react-refresh"
],
"ignorePatterns": [
"node_modules/",
"dist/",
"server.js",
"*.d.ts",
"*.config.ts"
],
"ignorePatterns": ["node_modules/", "dist/", "server.js", "*.d.ts"],
"extends": [
// extends mean use config from devDependencies that community created or recommended

Expand Down Expand Up @@ -58,7 +52,7 @@
"parserOptions": {
"sourceType": "module",
"ecmaVersion": "latest",
"project": "./tsconfig.json",
"project": ["./tsconfig.json", "./tsconfig.node.json"],
"ecmaFeatures": {
"jsx": true
}
Expand Down Expand Up @@ -129,7 +123,7 @@
},
"typescript": {
"alwaysTryTypes": true,
"project": "./tsconfig.json"
"project": ["./tsconfig.json", "./tsconfig.node.json"]
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.node.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"allowSyntheticDefaultImports": true,
"strict": true
},
"include": ["vite.config.ts"]
"include": ["vite.config.ts", "tailwind.config.ts"]
}

// why do we need this tsconfig.node.json??? because vite server run in node??? // or maybe need to convert .ts config file back to .js like tailwind.config.ts ??

0 comments on commit 23ace94

Please sign in to comment.