Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/new eslint config #104

Merged
merged 9 commits into from
Jun 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,7 @@
"jsx-a11y",
"react-refresh"
],
"ignorePatterns": [
"node_modules/",
"dist/",
"server.js",
"*.d.ts",
"*.config.ts"
],
"ignorePatterns": ["node_modules/", "dist/", "server.js", "*.d.ts"],
"extends": [
// extends mean use config from devDependencies that community created or recommended

Expand Down Expand Up @@ -58,7 +52,7 @@
"parserOptions": {
"sourceType": "module",
"ecmaVersion": "latest",
"project": "./tsconfig.json",
"project": ["./tsconfig.json", "./tsconfig.node.json"],
"ecmaFeatures": {
"jsx": true
}
Expand Down Expand Up @@ -129,7 +123,7 @@
},
"typescript": {
"alwaysTryTypes": true,
"project": "./tsconfig.json"
"project": ["./tsconfig.json", "./tsconfig.node.json"]
}
}
}
Expand Down
19 changes: 9 additions & 10 deletions .github/workflows/checkPR.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,18 +21,17 @@ jobs:
restore-keys: |
${{ runner.os }}-pnpm-standalone

- uses: pnpm/action-setup@v4
name: Install pnpm
# id: pnpmahihi
- name: Install pnpm
uses: pnpm/action-setup@v4
with:
version: 9
run_install: false
standalone: false

# - name: Install Node.js
# uses: actions/setup-node@v4
# with:
# node-version: 20
- name: Install node
uses: actions/setup-node@v4
with:
node-version: 20

# - name: which pnpm
# shell: bash
Expand All @@ -56,8 +55,8 @@ jobs:
# run: |
# echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV

- uses: actions/cache@v4
name: Setup pnpm node_module cache
- name: Setup pnpm node_module cache
uses: actions/cache@v4
with:
path: /home/runner/setup-pnpm/node_modules/.bin/store/v3
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
Expand All @@ -68,4 +67,4 @@ jobs:
run: pnpm install

- name: Lint
run: prettier:check && pnpm run eslint:check-allow-warning && pnpm run check-types
run: pnpm run prettier:check && pnpm run eslint:check-allow-warning && pnpm run check-types
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "https://json.schemastore.org/package.json",
"name": "pied_nike",
"name": "naikila_fe_main",
"private": true,
"version": "1.0.0",
"type": "module",
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.node.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"allowSyntheticDefaultImports": true,
"strict": true
},
"include": ["vite.config.ts"]
"include": ["vite.config.ts", "tailwind.config.ts"]
}

// why do we need this tsconfig.node.json??? because vite server run in node??? // or maybe need to convert .ts config file back to .js like tailwind.config.ts ??
Loading