-
Notifications
You must be signed in to change notification settings - Fork 1
Feat(client): job selection popup open condition change #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
a3265db
18bc517
8893f15
b4d5053
78f5e54
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| import { Icon } from '@pinback/design-system/icons'; | ||
| import { Button } from '@pinback/design-system/ui'; | ||
| import { useQueryClient } from '@tanstack/react-query'; | ||
| import formatRemindTime from '@shared/utils/formatRemindTime'; | ||
| import { useEffect, useRef } from 'react'; | ||
| import { useNavigate } from 'react-router-dom'; | ||
|
|
@@ -22,6 +23,7 @@ export default function ProfilePopup({ | |
| remindTime, | ||
| }: ProfilePopupProps) { | ||
| const navigate = useNavigate(); | ||
| const queryClient = useQueryClient(); | ||
| const popupRef = useRef<HTMLDivElement>(null); | ||
|
|
||
| useEffect(() => { | ||
|
|
@@ -42,6 +44,8 @@ export default function ProfilePopup({ | |
| const handleLogout = () => { | ||
| localStorage.removeItem('token'); | ||
| localStorage.removeItem('email'); | ||
| localStorage.removeItem('userId'); | ||
| queryClient.clear(); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ๋ก๊ทธ์์ ์ ๋จ์ํ ํ ํฐ๋ง ์ ๊ฑฐํ๋ฉด ๋๋ค๊ณ ์๊ฐํ๋๋ฐ React Query ์บ์์ ์ด์ ์ฌ์ฉ์ ๋ฐ์ดํฐ๊ฐ ๋จ์ ์์ ์ ์๋ค๋ ์ ์ ๋์ณค๋ค์ ํ ํฐ ์ญ์ ๋ฟ ์๋๋ผ ์บ์ ์ด๊ธฐํ๊น์ง ํจ๊ป ์ฒ๋ฆฌํ๋ ๊ฒ์ด ์ฌ์ฉ์ ์ ํ ์ ๋ฐ์ดํฐ ์ผ๊ด์ฑ๊ณผ ๋ณด์ ์ธก๋ฉด์์ ๋ ์์ ํ ๋ฐฉ๋ฒ์ด๋ผ๊ณ ์ดํดํ์ต๋๋ค. ํ๋ ๋ ๋ฐฐ์๊ฐ์-! |
||
| const sendExtensionLogout = () => { | ||
| window.postMessage( | ||
| { | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ ์ฑ /์ฝ๊ด ํ์ด์ง์์๋ ํผ๋์ด ์ด๋ฆด ์ ์์ด ๋ฒ์ ๋ฌธ์ ์ ๊ทผ์ ๋ง์ ์ ์์ต๋๋ค.
ํ์ฌ ์กฐ๊ฑด์ Line [29]-[32]์์
!isPolicyPage๋ฅผ ์ ์ธํ์ง ์์/policy,/terms์์๋ ๋ชจ๋ฌ์ด ๋ฐ ์ ์์ต๋๋ค. ํด๋น ๊ฒฝ๋ก๋ ํผ๋์์ ์ ์ธํ๋ ๊ฒ ์์ ํฉ๋๋ค.๐ง ์ ์ ์์ ์
const { data: hasJobData, isLoading: isHasJobLoading } = useGetHasJob( - isLoggedIn && !isAuthPage + isLoggedIn && !isAuthPage && !isPolicyPage ); const shouldShowJobSelectionFunnel = isLoggedIn && !isAuthPage && + !isPolicyPage && !isHasJobLoading && hasJobData?.hasJob === false;๐ค Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ด๋ถ๋ถ๋ ํ์ธํด๋ณด์ จ๋์ ?!?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jjangminii๋ค, ๋ง์ต๋๋ค! CodeRabbit์ด ์ง์ ํ ๋ถ๋ถ์ด ํ๋นํ ์ด์์ ๋๋ค.ํ์ฌ ์ฝ๋๋ฅผ ๋ณด๋ฉด
isPolicyPage๊ฐ ์ ์๋์ด ์์ง๋ง, ์ง๋ฌด ์ ํ ํผ๋์ ํ์ํ๋ ์กฐ๊ฑด์์๋ ์ ์ธ๋์ง ์๊ณ ์์ต๋๋ค. ์ด๋ก ์ธํด ๋ก๊ทธ์ธํ ์ฌ์ฉ์๊ฐ ์ด์ฉ์ฝ๊ด์ด๋ ๊ฐ์ธ์ ๋ณด์ฒ๋ฆฌ๋ฐฉ์นจ ํ์ด์ง๋ฅผ ๋ณผ ๋๋ ํผ๋ ๋ชจ๋ฌ์ด ๋ํ๋ ์ ์์ด์, ๋ฒ์ ๋ฌธ์ ์ ๊ทผ์ ๋ฐฉํดํ ์ ์๋ ๋ฌธ์ ๊ฐ ์์ต๋๋ค.๋ค์๊ณผ ๊ฐ์ด ์์ ํ๋ ๊ฒ์ ๊ถ์ฅํฉ๋๋ค:
์ด๋ ๊ฒ ํ๋ฉด:
hasJobAPI ์์ฒญ ์์ฒด๋ฅผ ํ์ง ์์There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ ๊ทธ๋ ๋ค์! ํด๋น ๋ถ๋ถ ์กฐ๊ฑด ์ถ๊ฐํ๊ฒ ์ต๋๋ค ๐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.