Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were keeping sleep state in several different places
sleepUntilMatch could return a boolean locally which was unused
local state was actually held in timer_match
then scheduledticks could be called to return if there were ticks left
Ive collapsed these keeping the timer_match as the internal class state variable.
For external scheduledticksleft() still exists, but is returned from dosleep so should never need to be called
The result is that scout can simplify sleepPending handling greatly.
Besides being better, I think Ill be persuing a state machine instead of booleans to control sleep state especially as I look at adding radio sleep to synchronize between scouts.
also theres a bunch of led indication stuff cluttering up the loop Id like to move out to an led handling function