Fix bugs and security vulnerabilities #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug fixes: - Fix Main class instantiation without required arguments (index.ts) - Fix error handling for non-Error objects in catch block (index.ts) - Fix integer parsing bug where '0' was treated as string (SelectionSets.ts) - Fix wrong variable used in error handling (QueryRunner.ts:142) - Fix iteration over generator using for...of instead of for...in (Actions.ts) - Fix type mismatch: use GraphQLOutputType instead of GraphQLNamedType (CommandRunner.ts, FieldInterpreter.ts) Security fixes: - Add path traversal protection for schema cache files (SchemaConnection.ts) - Sanitize project names to only allow alphanumeric, hyphens, underscores - Validate resolved paths stay within working directory These changes fix compilation errors that prevented the code from building. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes several bugs and security vulnerabilities that were preventing the code from compiling and could cause runtime issues.
Bug Fixes
Mainclass instantiation - was calling constructor without requiredactionsargumenterror.messagewould crash on non-Error objectsparseInt('0')returns0which is falsy, causing0to be treated as a string instead of an integererrors(from validation) instead ofresult.errorsfor...ofinstead offor...inGraphQLOutputTypeinstead ofGraphQLNamedTypeSecurity Fixes
../sequences to read/write files outside the intended directoryImpact
These changes fix compilation errors that prevented the code from building. The code now compiles successfully with
npm run compile.🤖 Generated with Claude Code