Merge pull request #23 from PipeRift/hotfix/general-fixes

Fixed crash on pool copy
PipeRift · Feb 25, 2023 · ccf8a9b · ccf8a9b
2 parents 4c99b71 + 81e184d
commit ccf8a9b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/Include/Pipe/Core/Optional.h b/Include/Pipe/Core/Optional.h
@@ -122,6 +122,15 @@ namespace p
 			       "use Get(defaultValue) instead.");
 			return value;
 		}
+		/** @return The optional value; undefined when IsSet() returns false. */
+		const Type* TryGet() const
+		{
+			return IsSet() ? &value : nullptr;
+		}
+		Type* TryGet()
+		{
+			return IsSet() ? &value : nullptr;
+		}
 
 		const Type& operator*() const
 		{

diff --git a/Src/ECS/BasePool.cpp b/Src/ECS/BasePool.cpp
@@ -17,7 +17,7 @@ namespace p::ecs
 		for (i32 i = 0; i < other.Size(); ++i)
 		{
 			const Id id = other.idList[i];
-			if (id != ecs::NoId)
+			if (ecs::GetVersion(id) != ecs::NoVersion)
 			{
 				EmplaceId(id, true);
 			}