-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Pdf munk components #18458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pdf munk components #18458
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
WalkthroughAdds four new actions for website and HTML conversion to image/PDF, implements a centralized HTTP client in pdf_munk.app.mjs with request helpers and API methods, and updates package.json to version 0.1.0 with a new @pipedream/platform dependency. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant Action as Action Module
participant App as pdf_munk.app.mjs
participant API as PDF Munk API
User->>Action: Provide props (e.g., url/html, options)
rect rgba(200,230,255,0.3)
note right of Action: New/updated flow
Action->>App: Call method (e.g., captureWebsiteToPdf({...}))
App->>App: _getHeaders() / _baseUrl()
App->>API: POST /{endpoint} with JSON body
API-->>App: Response (binary/meta)
end
App-->>Action: Return response
Action-->>User: Export $summary and result
alt Error
API-->>App: Error response
App-->>Action: Propagate error
Action-->>User: Error surfaced by runtime
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2024-12-12T19:23:09.039Z
Applied to files:
🧬 Code graph analysis (4)components/pdf_munk/actions/convert-html-to-image/convert-html-to-image.mjs (3)
components/pdf_munk/actions/capture-website-screenshot-into-image/capture-website-screenshot-into-image.mjs (3)
components/pdf_munk/actions/convert-html-to-pdf/convert-html-to-pdf.mjs (3)
components/pdf_munk/actions/capture-website-screenshot-into-pdf/capture-website-screenshot-into-pdf.mjs (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🔇 Additional comments (6)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified. |
Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:
|
Implements PDF Munk components (#17850)
Summary by CodeRabbit