Nocodb - update data prop type

[michelle0927]

Resolves #18473

Summary by CodeRabbit

• Bug Fixes

  • Improved input validation in the NocoDB app by requiring data to be a string, reducing invalid input issues. No other behavioral changes.

• Chores

  • Bumped NocoDB package to 0.1.1.
  • Incremented version numbers for NocoDB actions (add, delete, get, list matching criteria, update) and sources (new record, updated record, new record in view). No functional changes.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments

Project	Deployment	Preview	Comments	Updated (UTC)
pipedream-docs	Ignored			Sep 26, 2025 8:19pm
pipedream-docs-redirect-do-not-edit	Ignored			Sep 26, 2025 8:19pm

[coderabbitai]

Walkthrough

Multiple NocoDB components update exported version fields across actions and sources. The app definition changes the propDefinitions entry for data from type "any" to "string". The package version increments. No logic, control flow, or method signatures are modified.

Changes

Cohort / File(s)	Summary of Changes
Actions version bump components/nocodb/actions/add-record/add-record.mjs, components/nocodb/actions/delete-record/delete-record.mjs, components/nocodb/actions/get-record/get-record.mjs, components/nocodb/actions/list-records-matching-criteria/list-records-matching-criteria.mjs, components/nocodb/actions/update-record/update-record.mjs	Updated exported action version values: 0.0.5→0.0.6 (most), 0.0.6→0.0.7 (list-records-matching-criteria). No logic changes.
Sources version bump components/nocodb/sources/new-record/new-record.mjs, components/nocodb/sources/new-record-in-view/new-record-in-view.mjs, components/nocodb/sources/updated-record/updated-record.mjs	Updated exported source version values: new-record 0.0.6→0.0.7; new-record-in-view 0.0.1→0.0.2; updated-record 0.0.6→0.0.7.
App prop type update components/nocodb/nocodb.app.mjs	propDefinitions: data.type changed from "any" to "string".
Package version bump components/nocodb/package.json	Package version updated 0.1.0→0.1.1.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I twitch my ears at version chimes,
Small hops through files in tidy lines.
A string, not any, clear and bright—
The fields now nibble data right.
With whiskered joy, I stamp and thump,
Ship it quick—just a version bump! 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Out of Scope Changes Check	⚠️ Warning	The pull request includes version bumps across multiple Nocodb actions and source modules that are unrelated to the data prop type fix in issue #18473, introducing changes outside the stated objective.	Please isolate the data prop type change and limit version updates to the affected module or submit separate PRs for unrelated version bumps.
Description Check	⚠️ Warning	The description only includes a link to the issue and omits the required WHY section from the repository’s template, leaving the rationale for the change unspecified.	Please complete the pull request description using the repository template by adding the WHY section and explaining the motivation and context of the change.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title clearly and concisely summarizes the primary change of updating the data prop type in the Nocodb component, matching the pull request’s main objective without extraneous details.
Linked Issues Check	✅ Passed	The change to the data prop in nocodb.app.mjs from type any to string directly resolves the unsupported property type error described in issue #18473 and aligns with its objective.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch issue-18473

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

components/nocodb/actions/add-record/add-record.mjs (1)

8-8: Version bump — consider guarding JSON.parse for better UX

Since the data prop is now a string, invalid JSON will throw. Wrap parsing to surface a clear error.

Example change inside methods.processEvent:

let data = this.data;
if (typeof data === "string") {
  try {
    data = JSON.parse(data);
  } catch (err) {
    throw new Error("Invalid JSON for 'data'. Provide a valid JSON object string, e.g. {\"Name\":\"Alice\"}.");
  }
}
return this.nocodb.createTableRow({ tableId: this.tableId.value, data, $ });

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1f8bd63 and b8549a8.

📒 Files selected for processing (10)

• components/nocodb/actions/add-record/add-record.mjs (1 hunks)
• components/nocodb/actions/delete-record/delete-record.mjs (1 hunks)
• components/nocodb/actions/get-record/get-record.mjs (1 hunks)
• components/nocodb/actions/list-records-matching-criteria/list-records-matching-criteria.mjs (1 hunks)
• components/nocodb/actions/update-record/update-record.mjs (1 hunks)
• components/nocodb/nocodb.app.mjs (1 hunks)
• components/nocodb/package.json (1 hunks)
• components/nocodb/sources/new-record-in-view/new-record-in-view.mjs (1 hunks)
• components/nocodb/sources/new-record/new-record.mjs (1 hunks)
• components/nocodb/sources/updated-record/updated-record.mjs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Publish TypeScript components
• GitHub Check: Verify TypeScript components
• GitHub Check: Lint Code Base

🔇 Additional comments (9)

components/nocodb/actions/get-record/get-record.mjs (1)

8-8: Version bump only — LGTM

No functional changes. Safe to merge.

components/nocodb/sources/new-record/new-record.mjs (1)

9-9: Version bump only — LGTM

No behavior change.

components/nocodb/package.json (1)

3-3: Package version bump — LGTM

Matches component version updates.

components/nocodb/sources/updated-record/updated-record.mjs (1)

9-9: Version bump only — LGTM

No logic changes.

components/nocodb/actions/delete-record/delete-record.mjs (1)

8-8: Version bump only — LGTM

No functional change.

components/nocodb/actions/update-record/update-record.mjs (1)

8-8: Version bump — LGTM

Parsing-guard suggestion for data already covered in related comments to avoid duplication.

components/nocodb/nocodb.app.mjs (1)

94-97: Refine data prop copy, guard JSON parse, and audit remaining any-typed props

• Replace data prop as follows:

 data: {
-  type: "string",
-  label: "data",
-  description: "Enter Json Formated data",
+  type: "string",
+  label: "Data",
+  description: "JSON-formatted object of field values to write. Example: {\"Name\":\"Alice\",\"Status\":\"Active\"}",
 },

• Wrap JSON.parse in add/update actions with try/catch to provide clear error messages.
• Repo scan uncovered numerous type: "any" props (e.g. components/nocodb/…, zoom, visualping, xero, twist, etc.)—audit and convert these to prevent unsupported-property errors.

components/nocodb/actions/list-records-matching-criteria/list-records-matching-criteria.mjs (1)

8-8: Version bump aligns with the NocoDB update.

Matches the broader release sync for these actions.

components/nocodb/sources/new-record-in-view/new-record-in-view.mjs (1)

8-8: Source version update looks good.

Consistent with the latest release wave.

[luancazarine]

Hi @michelle0927, LGTM! Ready for QA!