[Do not merge] Verify safety properties with Apalache#8
Draft
Conversation
Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
…type system because all four messages are structurely idential. Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
that Apalache has to generate.
```shell
~/apalache/apalache-0.47.0/bin/apalache-mc --debug --smtprof --profiling check --length=1 APApirateship.tla
~/apalache/apalache-0.47.0/bin/apalache-mc --debug --smtprof --profiling check --length=2 APApirateship.tla
~/apalache/apalache-0.47.0/bin/apalache-mc --debug --smtprof --profiling check --length=3 APApirateship.tla
```
The original version of the model has the following
performance numbers:
--length=1,--length=2,--length=3
```shell
-> % ls -lah _apalache-out/APApirateship.tla/2024-11-13T*/log0.smt
-rw-r--r--@ 1 markus staff 4.3M Nov 13 11:44 _apalache-out/APApirateship.tla/2024-11-13T11-44-34_2659809425790680493/log0.smt
-rw-r--r--@ 1 markus staff 23M Nov 13 11:44 _apalache-out/APApirateship.tla/2024-11-13T11-44-43_6113641899789826029/log0.smt
-rw-r--r--@ 1 markus staff 86M Nov 13 11:45 _apalache-out/APApirateship.tla/2024-11-13T11-44-58_17093659918975460327/log0.smt
-> % for p in _apalache-out/APApirateship.tla/2024-11-13T*/profile.csv; do awk -F, '{sum += $1} END {print sum}' $p; done
91172
990065
4416763
```
With the various rewrites, we see a modest improvement:
--length=1,--length=2,--length=3
```shell
-> % ls -lah _apalache-out/APApirateship.tla/2024-11-13T*/log0.smt
-rw-r--r--@ 1 markus staff 3.6M Nov 13 11:37 _apalache-out/APApirateship.tla/2024-11-13T11-36-56_9321311001194045755/log0.smt
-rw-r--r--@ 1 markus staff 15M Nov 13 11:37 _apalache-out/APApirateship.tla/2024-11-13T11-37-05_4783214633623108253/log0.smt
-rw-r--r--@ 1 markus staff 41M Nov 13 11:37 _apalache-out/APApirateship.tla/2024-11-13T11-37-17_1888017297233515155/log0.smt
-> % for p in _apalache-out/APApirateship.tla/2024-11-13T11-3*/profile.csv; do awk -F, '{sum += $1} END {print sum}' $p; done
65685
465158
1404713
```
(compare "weight" in https://apalache-mc.org/docs/apalache/profiling.html)
Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
Collaborator
Author
|
FWIW, I believe they are, but I haven't verified that all my rewrites are equivalent with original definition. The main goal was to identify the root cause of the SMT constraint explosion. |
Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to verify safety properties using Apalache. However, Apalache currently cannot check this specification because modeling the
logandnetworkwith (ordered) sequences is a no-go. The commit message for 5b42a6b indicates that excessive SMT constraint explosion still occurs, even after eliminating Apalache antipatterns as recommended in https://apalache-mc.org/docs/apalache/antipatterns.html.Background reading: