cogito:protocol: address review comments

Pix4D · Oct 20, 2023 · b9f3ff2 · b9f3ff2
1 parent 6f61921
commit b9f3ff2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 17 deletions.
diff --git a/cmd/cogito/main_test.go b/cmd/cogito/main_test.go
@@ -67,11 +67,6 @@ func TestRunPutSuccess(t *testing.T) {
 	chatReply := googlechat.MessageReply{}
 	var gchatUrl *url.URL
 	googleChatSpy := testhelp.SpyHttpServer(&chatMsg, chatReply, &gchatUrl, http.StatusOK)
-	gitHubSpyDomain, err := url.Parse(gitHubSpy.URL)
-	if err != nil {
-		t.Fatalf("error parsing SpyHttpServer URL: %s", err)
-	}
-
 	in := bytes.NewReader(testhelp.ToJSON(t, cogito.PutRequest{
 		Source: cogito.Source{
 			Owner:             "the-owner",
@@ -85,6 +80,10 @@ func TestRunPutSuccess(t *testing.T) {
 	}))
 	var out bytes.Buffer
 	var logOut bytes.Buffer
+	gitHubSpyDomain, err := url.Parse(gitHubSpy.URL)
+	if err != nil {
+		t.Fatalf("error parsing SpyHttpServer URL: %s", err)
+	}
 	inputDir := testhelp.MakeGitRepoFromTestdata(t, "../../cogito/testdata/one-repo/a-repo",
 		testhelp.HttpsRemote(gitHubSpyDomain.Host, "the-owner", "the-repo"), "dummySHA", wantGitRef)
 

diff --git a/cogito/protocol_test.go b/cogito/protocol_test.go
@@ -111,7 +111,7 @@ func TestSourceValidationFailure(t *testing.T) {
 			wantErr: "source: invalid sink(s): [closed coffee shop]",
 		},
 		{
-			name: "no protocol prefix in git source github_api_endpoint",
+			name: "invalid URI: missing scheme in source.github_api_endpoint",
 			source: cogito.Source{
 				Owner:             "the-owner",
 				Repo:              "the-repo",
@@ -121,7 +121,7 @@ func TestSourceValidationFailure(t *testing.T) {
 			wantErr: "source: github_api_endpoint 'github.coffee.com/api/v3' is an invalid api endpoint",
 		},
 		{
-			name: "invalid http protocol prefix in git source github_api_endpoint",
+			name: "invalid URI: missing authorithy in source.github_api_endpoint",
 			source: cogito.Source{
 				Owner:             "the-owner",
 				Repo:              "the-repo",
@@ -130,16 +130,6 @@ func TestSourceValidationFailure(t *testing.T) {
 			},
 			wantErr: "source: github_api_endpoint 'https:github.coffee.com/api/v3' is an invalid api endpoint",
 		},
-		{
-			name: "invalid http protocol prefix in git source github_api_endpoint",
-			source: cogito.Source{
-				Owner:             "the-owner",
-				Repo:              "the-repo",
-				AccessToken:       "the-token",
-				GithubApiEndpoint: "john.smith.cim",
-			},
-			wantErr: "source: github_api_endpoint 'john.smith.cim' is an invalid api endpoint",
-		},
 	}
 
 	for _, tc := range testCases {