Add optional omit_target_url

[marco-m-pix4d]

While at it, did some cleanups and updated to Go 1.23

Closes #159.

[odormond]

As the GH API expect a string or null, wouldn't it be cleaner to pass null instead?
(https://docs.github.com/en/rest/commits/statuses?apiVersion=2022-11-28#create-a-commit-status)

[odormond]

I'm also tempted to do this before logging to avoid a misleading buildURL showing up in the logs

[marco-m-pix4d]

I'm also tempted to do this before logging to avoid a misleading buildURL showing up in the logs

That was my first iteration. Then I realized that the logging should still contain the buildURL, since the logging is not publicly accessible, and the goal of this PR is to omit the Concourse URL from a public GitHub PR page. Omitting also from the log would, in my understanding, make troubleshooting or auditing more difficult for no reason...

[marco-m-pix4d]

As the GH API expect a string or null, wouldn't it be cleaner to pass null instead? (https://docs.github.com/en/rest/commits/statuses?apiVersion=2022-11-28#create-a-commit-status)

The type of buildURL is a string, not a pointer to a string, so we cannot set it to nil. We could change the type to pointer to string, but that would bring pain everywhere else.

What we could do is to decorate the structure field TargetURL with tag omitempty

cogito/github/commitstatus.go

Lines 83 to 89 in a55a812

	// AddRequest is the JSON object sent to the API.
	type AddRequest struct {
	State string `json:"state"`
	TargetURL string `json:"target_url"`
	Description string `json:"description"`
	Context string `json:"context"`
	}

like this:

	TargetURL   string `json:"target_url,omitempty"`

omitempty will see an empty string (the value "") and will omit the field from the JSON object. This is not the same as setting the field to JSON null...

To summarize, I am tempted to say that if the GH API is happy with an empty string, that is good enough. But this discussion made me realize that I need to test this somehow.

UPDATE

Tested with empty "" targetUrl. Works as expected: adds a status check according to the passed parameters. Link "Details", that normally points to the targetURL, in this case points back to the commit page.

[marco-m-pix4d]

@odormond I am mentioning you here because I am going to merge this PR. I believe I addressed both your comments. If I missed something, ping me.