Decouple HTTP client and validator so we can verify responses outside Forms #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ikvasnica, |
(cherry picked from commit c8f7531)
|
matthieu2607
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm sending this PR as a result of our use case where we implemented the package into Symfony Forms. But then we needed to use Cloudflare Turnstile also within JavaScript part of the application where we don't use Symfony Forms, however we still need to validate Turnstile response using PHP backend.
The goal was to decouple HTTP client and Symfony Form Validator parts.
Plus I added a unit test for this part.