Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: PPT-1326 Add endpoint to provide a list of booking ids #323

Merged
merged 4 commits into from
Jul 1, 2024
Merged

feat: PPT-1326 Add endpoint to provide a list of booking ids #323

merged 4 commits into from
Jul 1, 2024

Conversation

naqvis
Copy link
Contributor

@naqvis naqvis commented Jun 28, 2024

No description provided.

@naqvis naqvis requested a review from stakach June 28, 2024 14:03
@github-actions github-actions bot added the type: enhancement new feature or request label Jun 28, 2024
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Jul 1, 2024
@naqvis naqvis requested a review from chillfox July 1, 2024 06:04
chillfox
chillfox approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@chillfox chillfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(only comments to update)

spec/controllers/bookings_spec.cr Outdated
@@ -39,6 +39,33 @@ describe Bookings do
body.size.should eq(1)
end

it "should return a list of bookings ids" do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should say asset ids instead of bookings ids

src/controllers/bookings.cr Outdated
@@ -259,6 +259,69 @@ class Bookings < Application
result
end

# lists bookings IDs based on the parameters provided
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be asset IDs instead of bookings IDs

@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Jul 1, 2024
@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Jul 1, 2024
@naqvis naqvis merged commit f70ee87 into master Jul 1, 2024
9 of 11 checks passed
@naqvis naqvis deleted the PPT-1326 branch July 1, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chillfox chillfox chillfox approved these changes

@stakach stakach Awaiting requested review from stakach

Assignees

@naqvis naqvis

Labels
type: enhancement new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naqvis @chillfox