Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: PPT-642 Added place controller #333

Merged
merged 2 commits into from
Sep 9, 2024
Merged

feat: PPT-642 Added place controller #333

merged 2 commits into from
Sep 9, 2024

Conversation

naqvis
Copy link
Contributor

@naqvis naqvis commented Sep 5, 2024

No description provided.

@naqvis naqvis requested a review from stakach September 5, 2024 04:08
@github-actions github-actions bot added the type: enhancement new feature or request label Sep 5, 2024
stakach
stakach requested changes Sep 5, 2024
View reviewed changes
Copy link
Member

@stakach stakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, should we also update the OPEN API docs?
Do a build and then can generate the docs using
./staff-api -d > ./OPENAPI_DOC.yml

(it'll complain about missing env vars, just export some random values and it will work)

@github-actions github-actions bot added type: enhancement new feature or request and removed type: enhancement new feature or request labels Sep 5, 2024
@naqvis naqvis requested a review from stakach September 5, 2024 05:01
stakach
stakach approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@stakach stakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stakach stakach merged commit b0394e6 into master Sep 9, 2024
11 checks passed
@stakach stakach deleted the PPT-642 branch September 9, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stakach stakach stakach approved these changes

Assignees

@naqvis naqvis

Labels
type: enhancement new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naqvis @stakach