Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate icons as SVGs and add new modeling constructs #50

Merged
merged 14 commits into from
Jul 20, 2023
Merged

Conversation

SharonNaemi
Copy link
Collaborator

@SharonNaemi SharonNaemi commented May 21, 2023

Short Description

Currently, the palette icons do not allow the dragstart action. Also the replace menu icons are looking blurred.

Proposed Changes

  • integrate all new icons
  • add circuit cutting task
  • add cutting result combination task

@mbeisel mbeisel self-requested a review June 15, 2023 10:40
Copy link
Collaborator

@mbeisel mbeisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really required to add thousands of LOCs for fontello, can the existing svgs not be directly included in the replace menu?

  • Some larger icons in the replace menu seem to remove all spacing between the icons and the text
  • Some larger icons exceed the spacing in the palette
  • It seems like fontello cant handle svgs containing color gradients, e.g., warm-starting icon, again raising the question if the palette and replace menu icons can not be included analogous to the task icons

grafik

@LaviniaStiliadou LaviniaStiliadou changed the title Integrate icons as SVGs Integrate icons as SVGs and add new modeling constructs Jul 19, 2023
@mbeisel mbeisel self-requested a review July 20, 2023 07:26
Copy link
Collaborator

@mbeisel mbeisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbeisel mbeisel merged commit 5912db3 into master Jul 20, 2023
1 check passed
@mbeisel mbeisel deleted the fix/icons branch July 20, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants