-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate icons as SVGs and add new modeling constructs #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: SharonNaemi <49727936+SharonNaemi@users.noreply.github.com>
mbeisel
requested changes
Jun 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it really required to add thousands of LOCs for fontello, can the existing svgs not be directly included in the replace menu?
- Some larger icons in the replace menu seem to remove all spacing between the icons and the text
- Some larger icons exceed the spacing in the palette
- It seems like fontello cant handle svgs containing color gradients, e.g., warm-starting icon, again raising the question if the palette and replace menu icons can not be included analogous to the task icons
Co-Authored-By: LaviniaStiliadou <livia_16@live.de>
LaviniaStiliadou
changed the title
Integrate icons as SVGs
Integrate icons as SVGs and add new modeling constructs
Jul 19, 2023
mbeisel
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
Currently, the palette icons do not allow the dragstart action. Also the replace menu icons are looking blurred.
Proposed Changes