-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix icons of data objects #88
Conversation
For testing purposes the following URL should be set as environment variable: DATA_CONFIG=https://raw.githubusercontent.com/PlanQK/workflow-modeler/fix/data-object-icons/components/bpmn-q/modeler-component/extensions/quantme/configurations/quantmeDataObjects.json Furthermore, the data plugin should be turned off: ENABLE_DATA_FLOW_PLUGIN=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DataObject Properties and Icons are missing. I assume that the custom dataobjects are not actually loaded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work by Lavinia and Benjamin
Should fix issue #77.