Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icons of data objects #88

Merged
merged 84 commits into from
Nov 10, 2023
Merged

Fix icons of data objects #88

merged 84 commits into from
Nov 10, 2023

Conversation

LaviniaStiliadou
Copy link
Contributor

Should fix issue #77.

@wederbn
Copy link
Collaborator

wederbn commented Oct 27, 2023

For testing purposes the following URL should be set as environment variable: DATA_CONFIG=https://raw.githubusercontent.com/PlanQK/workflow-modeler/fix/data-object-icons/components/bpmn-q/modeler-component/extensions/quantme/configurations/quantmeDataObjects.json

Furthermore, the data plugin should be turned off: ENABLE_DATA_FLOW_PLUGIN=false

@wederbn wederbn requested a review from mbeisel October 27, 2023 15:07
Copy link
Collaborator

@mbeisel mbeisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DataObject Properties and Icons are missing. I assume that the custom dataobjects are not actually loaded.

Copy link
Collaborator

@wederbn wederbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wederbn wederbn requested a review from mbeisel November 10, 2023 16:11
Copy link
Collaborator

@mbeisel mbeisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work by Lavinia and Benjamin

@wederbn wederbn merged commit 11a5b23 into master Nov 10, 2023
2 checks passed
@wederbn wederbn deleted the fix/data-object-icons branch November 10, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QuantME DataObject Icons don't work in Palette
4 participants