Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New diagram dialog #89

Merged
merged 3 commits into from
Oct 2, 2023
Merged

New diagram dialog #89

merged 3 commits into from
Oct 2, 2023

Conversation

LaviniaStiliadou
Copy link
Contributor

Should fix issue #75.

SharonNaemi and others added 2 commits September 17, 2023 16:40
Co-Authored-By: LaviniaStiliadou <livia_16@live.de>
@LaviniaStiliadou LaviniaStiliadou linked an issue Sep 17, 2023 that may be closed by this pull request
@mbeisel mbeisel self-requested a review September 27, 2023 11:11
Copy link
Collaborator

@mbeisel mbeisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM however, i think this branch should be merged into the linter instead of master

@wederbn wederbn changed the base branch from master to feature/linter October 2, 2023 07:18
@wederbn wederbn merged commit 4d42f49 into feature/linter Oct 2, 2023
2 checks passed
@wederbn wederbn deleted the fix/open-new-diagram branch October 2, 2023 07:20
LaviniaStiliadou added a commit that referenced this pull request Oct 23, 2023
* Add linter script and fix errors

* Apply prettier

* Add workflow executing linters

* Add working directory for npm ci

* Remove unknown working-directory from linting action

* Update linting workflow

* Fix linting command

* Fix NOTICE file

* Fix licence years

* Fix name in Github workflow

* Enable unused variable linting rule

* Run prettier

* Enable unnecessary espace rule

* Add .eslintignore

* Adapt path to public folder

* Update ignore rules for linters

* Lint changes after merging master

* Start fixing Readme

* Lint changes from merge

* Lint master merge

* Lint changes after merge with origin/master

* Replace renderer with correct file

* Lint changes

* Lint changes

* Run linter

* Fix lint error

* Add badges to readme

* New diagram dialog (#89)

* dialog for new diagram, isExecutable to true

Co-Authored-By: LaviniaStiliadou <livia_16@live.de>

* fix lint

* adjust label for canceling dialog

---------

Co-authored-by: SharonNaemi <naemi_17@live.de>
Co-authored-by: mbeisel <beiselmn@gmail.com>

* Fix plugin handling (#87)

* fix plugin handling

* fix lint

* remove useEffect as it overwrites the transformed workflow after opening it

* Fix transformation bugs

* Fix linting errors

* Temporarily add OpenTOSCAUtils to QuantME plugin

* Fix codestyle

* fix open modal

---------

Co-authored-by: LaviniaStiliadou <livia_16@live.de>
Co-authored-by: SharonNaemi <naemi_17@live.de>
Co-authored-by: mbeisel <beiselmn@gmail.com>
wederbn added a commit that referenced this pull request Oct 24, 2023
* Add linter script and fix errors

* Apply prettier

* Add workflow executing linters

* Add working directory for npm ci

* Remove unknown working-directory from linting action

* Update linting workflow

* Fix linting command

* Fix NOTICE file

* Fix licence years

* Fix name in Github workflow

* Enable unused variable linting rule

* Run prettier

* Enable unnecessary espace rule

* Add .eslintignore

* Adapt path to public folder

* Update ignore rules for linters

* Lint changes after merging master

* Start fixing Readme

* Lint changes from merge

* Lint master merge

* Lint changes after merge with origin/master

* Replace renderer with correct file

* Lint changes

* Lint changes

* Run linter

* Fix lint error

* Add badges to readme

* add scrollbar

* New diagram dialog (#89)

* dialog for new diagram, isExecutable to true

Co-Authored-By: LaviniaStiliadou <livia_16@live.de>

* fix lint

* adjust label for canceling dialog

---------

Co-authored-by: SharonNaemi <naemi_17@live.de>
Co-authored-by: mbeisel <beiselmn@gmail.com>

* Fix plugin handling (#87)

* fix plugin handling

* fix lint

* fix minLines and maxLines

* remove useEffect as it overwrites the transformed workflow after opening it

* Fix transformation bugs

* Fix linting errors

* Temporarily add OpenTOSCAUtils to QuantME plugin

* Fix codestyle

* fix open modal

* add scrollbar

* fix minLines and maxLines

* Remove comment

---------

Co-authored-by: Benjamin Weder <benjamin.weder@iaas.uni-stuttgart.de>
Co-authored-by: SharonNaemi <naemi_17@live.de>
Co-authored-by: mbeisel <beiselmn@gmail.com>
mbeisel added a commit that referenced this pull request Oct 24, 2023
* Add linter script and fix errors

* Apply prettier

* Add workflow executing linters

* Add working directory for npm ci

* Remove unknown working-directory from linting action

* Update linting workflow

* Fix linting command

* Fix NOTICE file

* Fix licence years

* Fix name in Github workflow

* Enable unused variable linting rule

* Run prettier

* Enable unnecessary espace rule

* Add .eslintignore

* Adapt path to public folder

* Update ignore rules for linters

* Lint changes after merging master

* Start fixing Readme

* Lint changes from merge

* Lint master merge

* Lint changes after merge with origin/master

* Replace renderer with correct file

* Lint changes

* Lint changes

* Run linter

* Fix lint error

* Add badges to readme

* change layout of config window, increase text field size, adjust config size

Co-Authored-By: LaviniaStiliadou <livia_16@live.de>

* move resizing logic from js function to css

* New diagram dialog (#89)

* dialog for new diagram, isExecutable to true

Co-Authored-By: LaviniaStiliadou <livia_16@live.de>

* fix lint

* adjust label for canceling dialog

---------

Co-authored-by: SharonNaemi <naemi_17@live.de>
Co-authored-by: mbeisel <beiselmn@gmail.com>

* Fix plugin handling (#87)

* fix plugin handling

* fix lint

* remove useEffect as it overwrites the transformed workflow after opening it

* Fix transformation bugs

* Fix linting errors

* Temporarily add OpenTOSCAUtils to QuantME plugin

* Fix codestyle

* fix open modal

* Add name for Dockerhub GitHub workflow

* Bump quantum workflow modeler version for upcoming release

* Add Dockerhub build for tags

* Add zip to supported files for Artifact (#101)

* change layout of config window, increase text field size, adjust config size

Co-Authored-By: LaviniaStiliadou <livia_16@live.de>

* move resizing logic from js function to css

---------

Co-authored-by: Benjamin Weder <benjamin.weder@iaas.uni-stuttgart.de>
Co-authored-by: LaviniaStiliadou <livia_16@live.de>
Co-authored-by: mbeisel <beiselmn@gmail.com>
Co-authored-by: Maximilian Kuhn <maximilian.kuhn@ymail.com>
wederbn added a commit that referenced this pull request Oct 27, 2023
* Add linter script and fix errors

* Apply prettier

* Add workflow executing linters

* Add working directory for npm ci

* Remove unknown working-directory from linting action

* Update linting workflow

* Fix linting command

* Fix NOTICE file

* Fix licence years

* Fix name in Github workflow

* Enable unused variable linting rule

* Run prettier

* Enable unnecessary espace rule

* Add .eslintignore

* Adapt path to public folder

* Update ignore rules for linters

* Lint changes after merging master

* Start fixing Readme

* Lint changes from merge

* Lint master merge

* Lint changes after merge with origin/master

* Replace renderer with correct file

* Lint changes

* Lint changes

* Run linter

* Fix lint error

* Add badges to readme

* New diagram dialog (#89)

* dialog for new diagram, isExecutable to true

Co-Authored-By: LaviniaStiliadou <livia_16@live.de>

* fix lint

* adjust label for canceling dialog

---------

Co-authored-by: SharonNaemi <naemi_17@live.de>
Co-authored-by: mbeisel <beiselmn@gmail.com>

* Fix plugin handling (#87)

* fix plugin handling

* fix lint

* add plugin pattern

* scale image

* allow to select patterns

* store patterns correctly with each button

* allow drag & drop

* align buttons horizontally

* fix layout of button, add endpointurl

* open modal to select algorithmic patterns

* fix selecting patterns to algorithmic patterns

* fix warning when setting endpoint

* add error message when endpoint is incorrect

* update text

* remove unused classes, change icon

* fix selected patterns for modal

* modify selection modal

* change position

* add delete

* add message to select algorithm pattern

* fix edit

* fix selected content

* remove quantme from pattern plugin

* change adaptation to pattern selection

* remove files

* fix layout

* fix lint

* return result

* fix tests

* adjust + button position

* disable button if response is invalid

* Fix comment for PatternConfigTab

* Fix comments for config-manager.js

* Change button style

* Remove comment

* Remove unused methods

* Refactor http fetch function to general utility class

* remove comments

* Remove unused methods

* Add copyright statements

* Remove wrong comment

* change icon

* fix lint

* Small changes for pattern intro text

* Remove comma

* Inline variables

* Fix button naming

* Move pattern categories to constants

* Remove pattern.json

* Update default config

* Activate plugins for tests

---------

Co-authored-by: Benjamin Weder <benjamin.weder@iaas.uni-stuttgart.de>
Co-authored-by: SharonNaemi <naemi_17@live.de>
Co-authored-by: mbeisel <beiselmn@gmail.com>
wederbn added a commit that referenced this pull request Nov 10, 2023
* Add linter script and fix errors

* Apply prettier

* Add workflow executing linters

* Add working directory for npm ci

* Remove unknown working-directory from linting action

* Update linting workflow

* Fix linting command

* Fix NOTICE file

* Fix licence years

* Fix name in Github workflow

* Enable unused variable linting rule

* Run prettier

* Enable unnecessary espace rule

* Add .eslintignore

* Adapt path to public folder

* Update ignore rules for linters

* Lint changes after merging master

* Start fixing Readme

* Lint changes from merge

* Lint master merge

* Lint changes after merge with origin/master

* Replace renderer with correct file

* Lint changes

* Lint changes

* Run linter

* Fix lint error

* Add badges to readme

* add className to data object configuration

Co-Authored-By: LaviniaStiliadou <livia_16@live.de>

* fix lint

* fix test

* New diagram dialog (#89)

* dialog for new diagram, isExecutable to true

Co-Authored-By: LaviniaStiliadou <livia_16@live.de>

* fix lint

* adjust label for canceling dialog

---------

Co-authored-by: SharonNaemi <naemi_17@live.de>
Co-authored-by: mbeisel <beiselmn@gmail.com>

* Fix plugin handling (#87)

* fix plugin handling

* fix lint

* remove useEffect as it overwrites the transformed workflow after opening it

* Fix transformation bugs

* Fix linting errors

* Temporarily add OpenTOSCAUtils to QuantME plugin

* Fix codestyle

* fix open modal

* add className to data object configuration

Co-Authored-By: LaviniaStiliadou <livia_16@live.de>

* fix lint

* fix test

* update endpoint

* fix test

* Change base construct for QuantME data objects

* Start refactoring QuantME data objects to remove dependency to data plugin

* Restore accidentally removed icon

* Change bindTo for QuantME data objects to default

* Fix test setup

* Fix linting

* remove dependency

* fix props

* add prefix

* fix properties, remove dependency

* rename group to details, disable name field

* remove data configuration endpoint, add dataobjects to quantme4bpmn

* add properties of data objects

* fix override

* add transformation

* replace icons in menu

* remove configuration

* Remove unused QuantMEKeyValueMap

* Remove unused method

* Linting

* Skip QRM search for data objects and HW selection

---------

Co-authored-by: Benjamin Weder <benjamin.weder@iaas.uni-stuttgart.de>
Co-authored-by: SharonNaemi <naemi_17@live.de>
Co-authored-by: mbeisel <beiselmn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dialog when openening new diagram
4 participants