Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing scrollbar in xml viewer #91

Merged
merged 54 commits into from
Oct 24, 2023
Merged

Fix missing scrollbar in xml viewer #91

merged 54 commits into from
Oct 24, 2023

Conversation

LaviniaStiliadou
Copy link
Contributor

Should fix issue #79.

@wederbn
Add linter script and fix errors
3a9f2c0
@wederbn
Apply prettier
9f73435
@wederbn
Add workflow executing linters
0a6a75b
@wederbn
Add working directory for npm ci
68b4b61
@wederbn
Remove unknown working-directory from linting action
79a3a16
@wederbn
Update linting workflow
2352f74
@wederbn
Fix linting command
1962832
@wederbn
Fix NOTICE file
e5c1604
@wederbn
Fix licence years
160145f
@wederbn
Fix name in Github workflow
0fd5db2
@wederbn
Enable unused variable linting rule
dd1fabb
@wederbn
Run prettier
d2577e6
@wederbn
Enable unnecessary espace rule
c0f4696
@wederbn
Add .eslintignore
25df57a
@wederbn
Adapt path to public folder
1645c45
@wederbn
Update ignore rules for linters
9a22188
@wederbn
Merge remote-tracking branch 'origin/master' into feature/linter
5fd8cd4
@wederbn
Lint changes after merging master
cb38a43
@wederbn
Start fixing Readme
d081013
@wederbn
Merge remote-tracking branch 'origin/master' into feature/linter
606b709
@wederbn
Lint changes from merge
4d3602d
@wederbn
Merge remote-tracking branch 'origin/master' into feature/linter
60444dc
@wederbn
Lint master merge
452e3a3
@wederbn
Merge remote-tracking branch 'origin/master' into feature/linter
85c3736
@wederbn
Lint changes after merge with origin/master
65f4136
@wederbn
Replace renderer with correct file
dbc8ef8
@wederbn
Merge remote-tracking branch 'origin/master' into feature/linter
25b38d5
@wederbn
Lint changes
a28f6dd
@wederbn
Merge remote-tracking branch 'origin/master' into feature/linter
4e14fe7
@wederbn
Merge remote-tracking branch 'origin/master' into feature/linter
82c83da
@LaviniaStiliadou LaviniaStiliadou linked an issue Sep 18, 2023 that may be closed by this pull request
XML Viewer content outside of viewable area #79
Closed
mbeisel
mbeisel requested changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@mbeisel mbeisel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well!

However, at the bottom of the Workflow modeler there is a whitespace - when opening the XML-Viewer it is even larger than usual. Can the whitespace be removed altogether or at least remain the same when opening the XML viewer?
grafik

components/bpmn-q/modeler-component/QuantumWorkflowModeler.js Outdated Show resolved Hide resolved
LaviniaStiliadou and others added 3 commits October 2, 2023 09:20
@LaviniaStiliadou @SharonNaemi @mbeisel
New diagram dialog (#89)
4d42f49 
* dialog for new diagram, isExecutable to true

Co-Authored-By: LaviniaStiliadou <livia_16@live.de>

* fix lint

* adjust label for canceling dialog

---------

Co-authored-by: SharonNaemi <naemi_17@live.de>
Co-authored-by: mbeisel <beiselmn@gmail.com>
@LaviniaStiliadou
Fix plugin handling (#87)
9a3c9be 
* fix plugin handling

* fix lint
@LaviniaStiliadou
fix minLines and maxLines
a426156
@wederbn wederbn changed the base branch from master to feature/linter October 5, 2023 07:18
@wederbn wederbn requested a review from mbeisel October 13, 2023 10:52
Base automatically changed from feature/linter to master October 23, 2023 14:29
wederbn
wederbn approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@wederbn wederbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wederbn wederbn merged commit 803fbc9 into master Oct 24, 2023
2 checks passed
@wederbn wederbn deleted the fix/xml-viewer branch October 24, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wederbn wederbn wederbn approved these changes

@mbeisel mbeisel Awaiting requested review from mbeisel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XML Viewer content outside of viewable area
3 participants
@LaviniaStiliadou @mbeisel @wederbn