Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support named slice types in API #9

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Support named slice types in API #9

merged 1 commit into from
Oct 26, 2023

Conversation

korya
Copy link
Contributor

@korya korya commented Oct 25, 2023

Change the API to support named slice types such as

type mySlice []int

This allows preserving the type in some functions. For example:

type mySlice []int

s1 := mySlice{1,2,3}
s2 := Filter(s1, func (n int) bool { return n > 1 })
// The type of s2 is mySlice

More details can be found in https://go.dev/blog/deconstructing-type-parameters

Change the API to support named slice types such as

    type mySlice []int

This allows preserving the type in some functions. For example:

    type mySlice []int

    s1 := mySlice{1,2,3}
    s2 := Filter(s1, func (n int) bool { return n > 1 })
    // The type of s2 is mySlice

More details can be found in https://go.dev/blog/deconstructing-type-parameters
gitstream-cm[bot]
gitstream-cm bot previously requested changes Oct 25, 2023
Copy link

@gitstream-cm gitstream-cm bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is missing a reference to Jira ticket:

  • Jira ticket ID should be appended to the PR title

  • Jira ticket URL should be added as a list item in the Related section (- https://planitar.atlassian.net/browse/{ID})

Make sure you provide links to relevant context (Jira tasks, Github issues, other PRs) as follows:
Github integration

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6647216795

  • 33 of 33 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 6490433747: 0.0%
Covered Lines: 135
Relevant Lines: 135

💛 - Coveralls

@gitstream-cm
Copy link

gitstream-cm bot commented Oct 25, 2023

🥷 Code experts: no user but you matched threshold 10

korya has most 👩‍💻 activity in the files.
korya has most 🧠 knowledge in the files.

See details

slc.go

Activity based on git-commit:

korya
OCT
SEP
AUG 257 additions & 4 deletions
JUL
JUN
MAY

Knowledge based on git-blame:
korya: 100%

slc_test.go

Activity based on git-commit:

korya
OCT
SEP
AUG 1451 additions & 117 deletions
JUL
JUN
MAY

Knowledge based on git-blame:
korya: 100%

To learn more about /:\ gitStream - Visit our Docs

@korya korya requested review from flpsan, adamdupuis and orihab October 25, 2023 23:11
gitstream-cm[bot]
gitstream-cm bot previously requested changes Oct 25, 2023
Copy link

@gitstream-cm gitstream-cm bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is missing a reference to Jira ticket:

  • Jira ticket ID should be appended to the PR title

  • Jira ticket URL should be added as a list item in the Related section (- https://planitar.atlassian.net/browse/{ID})

Make sure you provide links to relevant context (Jira tasks, Github issues, other PRs) as follows:
Github integration

@gitstream-cm gitstream-cm bot dismissed their stale review October 25, 2023 23:21

Review resolved

gitstream-cm[bot]
gitstream-cm bot previously requested changes Oct 26, 2023
Copy link

@gitstream-cm gitstream-cm bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is missing a reference to Jira ticket:

  • Jira ticket ID should be appended to the PR title

  • Jira ticket URL should be added as a list item in the Related section (- https://planitar.atlassian.net/browse/{ID})

Make sure you provide links to relevant context (Jira tasks, Github issues, other PRs) as follows:
Github integration

@gitstream-cm gitstream-cm bot dismissed their stale review October 26, 2023 04:15

Review resolved

Copy link

@gitstream-cm gitstream-cm bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is missing a reference to Jira ticket:

  • Jira ticket ID should be appended to the PR title

  • Jira ticket URL should be added as a list item in the Related section (- https://planitar.atlassian.net/browse/{ID})

Make sure you provide links to relevant context (Jira tasks, Github issues, other PRs) as follows:
Github integration

@gitstream-cm gitstream-cm bot dismissed their stale review October 26, 2023 13:13

Review resolved

@korya korya merged commit 91d2720 into master Oct 26, 2023
5 of 7 checks passed
@korya korya deleted the support-named-slices branch October 26, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants