Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continued mods for SAM #633

Merged
merged 18 commits into from
Jan 2, 2025
Merged

Continued mods for SAM #633

merged 18 commits into from
Jan 2, 2025

Conversation

simsong
Copy link
Member

@simsong simsong commented Dec 30, 2024

  • Move binaries out of webapp/deploy/static and to the static site.
  • Update all references in html
  • Get self-test working again.
  • Put default .ini file in etc/ directory
  • Add a log message to planttracer so that it puts the ini file it is using in the logs.
  • Add a message variable to the logger so the message is pulled out of the ini file
  • Add support for SMTP configuration in AWS Secrets

Closes #632

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 76.06838% with 28 lines in your changes missing coverage. Please review.

Project coverage is 69.38%. Comparing base (35de20f) to head (27cedd4).

Files with missing lines Patch % Lines
deploy/app/dbfile.py 20.00% 16 Missing ⚠️
deploy/app/auth.py 20.00% 8 Missing ⚠️
standalone.py 0.00% 2 Missing ⚠️
deploy/lambda_handler.py 66.66% 1 Missing ⚠️
tests/api/test_handler.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #633      +/-   ##
==========================================
- Coverage   69.41%   69.38%   -0.03%     
==========================================
  Files          34       34              
  Lines        3815     3831      +16     
  Branches       64       64              
==========================================
+ Hits         2648     2658      +10     
- Misses       1142     1148       +6     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simsong
Copy link
Member Author

simsong commented Jan 2, 2025

Getting closer.
image

@simsong simsong marked this pull request as ready for review January 2, 2025 23:09
@simsong simsong merged commit 25487e2 into main Jan 2, 2025
3 of 5 checks passed
@simsong simsong deleted the dev-sam branch January 2, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move all binary data out of webapp:deploy/static
1 participant