-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy onto AWS EC2 instance #639
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #639 +/- ##
==========================================
- Coverage 70.49% 70.36% -0.13%
==========================================
Files 35 36 +1
Lines 3853 3884 +31
Branches 64 64
==========================================
+ Hits 2716 2733 +17
- Misses 1112 1126 +14
Partials 25 25 ☔ View full report in Codecov by Sentry. |
@sbarber2 - ready for review. |
renaming files and updating doc will come in next PR. |
@@ -70,3 +70,7 @@ Keep your Lambda functions optimized for performance and cost. | |||
|
|||
# Lambda and S3 | |||
Lamda limits returns to 6MB and uploads to around 256K. So large uploads are done with presigned POST to S3 and large downloads by putting the data into S3 and having it pulled with a presigned URL. | |||
|
|||
|
|||
colima start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reference to colima is without context. Why is it here? Wouldn't it go in the MacOS section, in any case?
|
||
|
||
colima start | ||
docker ps -a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line also begs further explanation, please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The two comments I made are fine to address in doc updates part of the next PR.
Adapt to running on a stand-alone server on AWS. Specifically:
deploy/
(Deploy server to AWS EC2 #645)/
but not indeploy/
(Deploy server to AWS EC2 #645)gunicorn
andsystemd
service file. (Deploy server to AWS EC2 #645)