Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy onto AWS EC2 instance #639

Merged
merged 26 commits into from
Jan 26, 2025
Merged

Deploy onto AWS EC2 instance #639

merged 26 commits into from
Jan 26, 2025

Conversation

simsong
Copy link
Member

@simsong simsong commented Jan 17, 2025

Adapt to running on a stand-alone server on AWS. Specifically:

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 71.05263% with 22 lines in your changes missing coverage. Please review.

Project coverage is 70.36%. Comparing base (69a380e) to head (b5db967).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
dbutil.py 0.00% 10 Missing ⚠️
deploy/app/paths.py 50.00% 4 Missing ⚠️
standalone.py 0.00% 3 Missing ⚠️
deploy/app/bottle_app.py 93.10% 2 Missing ⚠️
deploy/app/apikey.py 92.30% 1 Missing ⚠️
deploy/app/db_object.py 50.00% 1 Missing ⚠️
deploy/lambda_handler.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #639      +/-   ##
==========================================
- Coverage   70.49%   70.36%   -0.13%     
==========================================
  Files          35       36       +1     
  Lines        3853     3884      +31     
  Branches       64       64              
==========================================
+ Hits         2716     2733      +17     
- Misses       1112     1126      +14     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simsong simsong changed the title Dev aws Deploy onto AWS instance Jan 25, 2025
@simsong simsong marked this pull request as ready for review January 25, 2025 19:08
@simsong
Copy link
Member Author

simsong commented Jan 25, 2025

@sbarber2 - ready for review.

@simsong
Copy link
Member Author

simsong commented Jan 25, 2025

renaming files and updating doc will come in next PR.

@sbarber2 sbarber2 added this to the Jan2025 milestone Jan 26, 2025
@@ -70,3 +70,7 @@ Keep your Lambda functions optimized for performance and cost.

# Lambda and S3
Lamda limits returns to 6MB and uploads to around 256K. So large uploads are done with presigned POST to S3 and large downloads by putting the data into S3 and having it pulled with a presigned URL.


colima start
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reference to colima is without context. Why is it here? Wouldn't it go in the MacOS section, in any case?



colima start
docker ps -a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line also begs further explanation, please.

Copy link
Contributor

@sbarber2 sbarber2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two comments I made are fine to address in doc updates part of the next PR.

This was referenced Jan 26, 2025
@sbarber2 sbarber2 changed the title Deploy onto AWS instance Deploy onto AWS EC2 instance Jan 26, 2025
@sbarber2 sbarber2 merged commit 3e23ffc into main Jan 26, 2025
7 checks passed
@sbarber2 sbarber2 deleted the dev-aws branch January 26, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set movie file upload size limit to 150MB Migrate from Bottle to Flask
2 participants