Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running a local standalone server #651

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

sbarber2
Copy link
Contributor

Update the top-level Makefile to use standalone.py, etc.

Closes #650

top-level Makefile. Update dev setup docs.
@sbarber2 sbarber2 linked an issue Jan 29, 2025 that may be closed by this pull request
@sbarber2 sbarber2 requested a review from simsong January 29, 2025 21:50
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.36%. Comparing base (3e23ffc) to head (8f6516a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #651   +/-   ##
=======================================
  Coverage   70.36%   70.36%           
=======================================
  Files          36       36           
  Lines        3884     3884           
  Branches       64       64           
=======================================
  Hits         2733     2733           
  Misses       1126     1126           
  Partials       25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@simsong simsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, yes, I moved standalone.py out of deploy/app because standalone.py doesn't need to be deployed.

@simsong
Copy link
Member

simsong commented Jan 29, 2025

I wonder if we could test this as part of our ci/CD...

@simsong simsong merged commit 1d4849d into main Jan 29, 2025
7 checks passed
@simsong simsong deleted the 650-fix-running-a-local-webapp-server branch January 29, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix running a local webapp server
2 participants