Integrate unitType
#424
Merged
Integrate unitType
#424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- marks `unit` as deprecated - updates to `unitType` throughout code
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- only for tree/conservation projects
- this is seen in the Left Panel - Also converts `getAdditionalInfo` into a pure function - Also adds a separate type definition for UnitType
* PC = PlanetCash
- updates planet-sdk to get latest `Donation` type - adapts thank you message and image text for donations with unitType = m2 and purpose = trees
mohitb35
force-pushed
the
feature/integrate-unit-type
branch
from
c81230e
to
7048de0
Compare
mohitb35
force-pushed
the
feature/integrate-unit-type
branch
from
7048de0
to
ed3b911
Compare
- disables inv. gifts for "trees+m2" donations - enables PC payment only for "unitType: tree" donations
mohitb35
force-pushed
the
feature/integrate-unit-type
branch
from
ed3b911
to
3976a99
Compare
| donation.destination && donation.units | ||
| ? " " + | ||
| t("common:restorationDonationUsage", { | ||
| units: donation.units, |
There was a problem hiding this comment.
Don't we want to format donation.units any more at all in the UI (I know you do not know if this is a number of trees, square meter or amount of currency)? (E.g. in src/Donations/LeftPanel/TransactionSummary.tsx we also use a function getAdditionalInfo to format the number depending on the unitType.)
There was a problem hiding this comment.
Yes, thank you for pointing this out. I've fixed it in f01b7e8
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
unitTypein Donations Form and Left Panel (Transaction Summary)unitTypein Thank you screen