Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double locale bug in back navigation #2408

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mohitb35
Copy link
Collaborator

@mohitb35 mohitb35 commented Feb 18, 2025

Resolve an issue with back navigation that caused double locale entries by improving the logic for handling paths that already contain locales.

To reproduce issue:

  • Open https://dev.pp.eco/en/yucatan in a new browser tab. After the page loads, press back. You should see the url https://dev.pp.eco/en/en and an error message ("Resource not found").

  • Try out the same approach with the preview link in this PR (append /yucatan or /en/yucatan after the link), the issue should no longer be seen

- improves logic to handle paths already containing locales
Copy link

vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
planet-webapp-multi-tenancy-setup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 10:42am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
planet-webapp ⬜️ Ignored (Inspect) Feb 18, 2025 10:42am
planet-webapp-temp ⬜️ Ignored (Inspect) Feb 18, 2025 10:42am

Copy link
Contributor

coderabbitai bot commented Feb 18, 2025

Walkthrough

This change refines the logic within the getLocalizedPath function in the src/utils/projectV2.ts file. The function now splits the input path into segments and checks if the first segment matches the locale rather than simply verifying if the path starts with the locale. The accompanying comments have been updated for clarity. There are no modifications to any exported or public entities.

Changes

File Summary
src/utils/projectV2.ts Updated getLocalizedPath to split the path into segments and check the first segment for the locale. Comments have been revised accordingly.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant F as getLocalizedPath

    U->>F: Call getLocalizedPath(path, locale)
    F->>F: Split path into segments
    F->>F: Check if first segment equals locale
    alt Locale matches
        F->>U: Return original path
    else Locale does not match
        F->>F: Insert locale into path
        F->>U: Return updated path
    end
Loading

Suggested labels

PR: unreviewed

Suggested reviewers

  • mariahosfeld

Poem

I'm a rabbit hopping through the code,
Splitting paths with a joyful mode.
Locale checks now sparkle bright,
Guiding paths both day and night.
Bugs scatter—oh, what a delightful sight! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 446878e and 2d66278.

📒 Files selected for processing (1)
  • src/utils/projectV2.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: ESLint on Ubuntu
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
src/utils/projectV2.ts (1)

265-267: LGTM! More robust locale path handling.

The new implementation correctly prevents double locale issues by precisely checking if the locale exists as a distinct path segment. This is more accurate than string prefix matching and prevents false matches with similar prefixes (e.g., 'en' vs 'en-US').

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@mariahosfeld mariahosfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I no longer encounter the "Ressource not found" issue, the map is not really zooming out now, and is basically "stuck" on Africa. Tested in normal browser-window as well as incognito.

@mohitb35
Copy link
Collaborator Author

While I no longer encounter the "Ressource not found" issue, the map is not really zooming out now, and is basically "stuck" on Africa. Tested in normal browser-window as well as incognito.

That's a non related existing bug on the map. It seems like this happens when the project details page is directly opened. I've added this as an issue and will look into it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants