Add LoadXML function to WeberPennTree plugin #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a function to load custom tree definitions from XML files, as currently available in the core Helios.
Unit tests have been added to add coverage to the new functionality.
Note that an absolute path is required for the XML. I had to implement the new function
buildTreeFromNamebecausebuildTreeonly acceptsWPTType. It would be nicer to generalise the tree names and add new tree definitions to the hard-coded trees, so that loading an XML file adds new names. A function likegetAvailableTreeTypescould provide all the available names, but it would require adding a new public method intoWeberPennTree.handWeberPennTree.cpp.E.g,:
Then it would be possible to expose this function in Python and avoid hardcoding
WPTType.