You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think there might be an issue with CoilSets if there are spline curves that have different breakpoints. We only vmap over params, not transforms, since its assumed that every coil in a CoilSet can use the same transforms. I think this is also an issue if they have different knots after #1099
Possible fixes:
move knots and intervals back to params instead of transforms (not sure if this will work, what was the reason they were moved in the first place?)
Add logic to desc.coils._check_type to ensure that knots and intervals are the same for all SplineXYZCoil in a CoilSet
I think there might be an issue with
CoilSet
s if there are spline curves that have different breakpoints. We only vmap over params, not transforms, since its assumed that every coil in aCoilSet
can use the same transforms. I think this is also an issue if they have different knots after #1099Possible fixes:
knots
andintervals
back toparams
instead oftransforms
(not sure if this will work, what was the reason they were moved in the first place?)desc.coils._check_type
to ensure thatknots
andintervals
are the same for allSplineXYZCoil
in aCoilSet
Originally posted by @f0uriest in #970 (review)
Confirmed this is an issue on master:
The text was updated successfully, but these errors were encountered: