Remove old _optimize method and the test

[YigitElma]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.86%. Comparing base (7ce6b87) to head (73952d9).
Report is 1870 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1066      +/-   ##
==========================================
- Coverage   94.96%   94.86%   -0.10%     
==========================================
  Files          87       87              
  Lines       21776    21711      -65     
==========================================
- Hits        20680    20597      -83     
- Misses       1096     1114      +18     

Files with missing lines	Coverage Δ
desc/equilibrium/equilibrium.py	96.29% <ø> (+0.20%)	⬆️

... and 1 file with indirect coverage changes

[github-actions]

|             benchmark_name             |         dt(%)          |         dt(s)          |        t_new(s)        |        t_old(s)        | 
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
 test_build_transform_fft_lowres         |     +3.77 +/- 4.37     | +1.98e-02 +/- 2.30e-02 |  5.46e-01 +/- 2.0e-02  |  5.26e-01 +/- 1.2e-02  |
 test_build_transform_fft_midres         |     +6.59 +/- 3.19     | +3.96e-02 +/- 1.92e-02 |  6.40e-01 +/- 1.7e-02  |  6.01e-01 +/- 9.1e-03  |
 test_build_transform_fft_highres        |     +3.49 +/- 4.39     | +3.49e-02 +/- 4.38e-02 |  1.03e+00 +/- 3.1e-02  |  9.99e-01 +/- 3.1e-02  |
 test_equilibrium_init_lowres            |     +6.97 +/- 3.01     | +2.65e-01 +/- 1.15e-01 |  4.07e+00 +/- 1.1e-01  |  3.81e+00 +/- 1.3e-02  |
 test_equilibrium_init_medres            |     +8.20 +/- 3.45     | +3.48e-01 +/- 1.46e-01 |  4.59e+00 +/- 1.4e-01  |  4.24e+00 +/- 4.6e-02  |
-test_equilibrium_init_highres           |     +5.94 +/- 1.84     | +3.39e-01 +/- 1.05e-01 |  6.05e+00 +/- 1.0e-01  |  5.71e+00 +/- 2.7e-02  |
 test_objective_compile_dshape_current   |     +2.55 +/- 1.72     | +9.86e-02 +/- 6.66e-02 |  3.96e+00 +/- 6.3e-02  |  3.86e+00 +/- 2.2e-02  |
 test_objective_compile_atf              |     +1.59 +/- 2.19     | +1.32e-01 +/- 1.82e-01 |  8.40e+00 +/- 1.7e-01  |  8.27e+00 +/- 7.3e-02  |
 test_objective_compute_dshape_current   |     +5.10 +/- 3.81     | +5.82e-05 +/- 4.35e-05 |  1.20e-03 +/- 3.0e-05  |  1.14e-03 +/- 3.2e-05  |
 test_objective_compute_atf              |     +4.65 +/- 6.63     | +1.87e-04 +/- 2.66e-04 |  4.21e-03 +/- 2.1e-04  |  4.02e-03 +/- 1.6e-04  |
 test_objective_jac_dshape_current       |     +7.49 +/- 7.90     | +2.73e-03 +/- 2.88e-03 |  3.91e-02 +/- 2.1e-03  |  3.64e-02 +/- 2.0e-03  |
 test_objective_jac_atf                  |     -1.84 +/- 2.33     | -3.46e-02 +/- 4.39e-02 |  1.85e+00 +/- 2.5e-02  |  1.89e+00 +/- 3.6e-02  |
 test_perturb_1                          |     +0.98 +/- 1.42     | +1.30e-01 +/- 1.87e-01 |  1.33e+01 +/- 1.8e-01  |  1.32e+01 +/- 4.5e-02  |
 test_perturb_2                          |     +0.26 +/- 1.47     | +4.69e-02 +/- 2.67e-01 |  1.82e+01 +/- 2.1e-01  |  1.81e+01 +/- 1.6e-01  |
 test_proximal_jac_atf                   |     -0.45 +/- 1.06     | -3.28e-02 +/- 7.78e-02 |  7.31e+00 +/- 5.6e-02  |  7.34e+00 +/- 5.4e-02  |
 test_proximal_freeb_compute             |     -0.96 +/- 0.63     | -1.70e-03 +/- 1.11e-03 |  1.76e-01 +/- 7.3e-04  |  1.77e-01 +/- 8.4e-04  |
 test_proximal_freeb_jac                 |     -0.00 +/- 1.04     | -3.25e-04 +/- 7.65e-02 |  7.33e+00 +/- 5.0e-02  |  7.33e+00 +/- 5.8e-02  |
 test_solve_fixed_iter                   |     +0.25 +/- 7.42     | +3.60e-02 +/- 1.09e+00 |  1.47e+01 +/- 7.8e-01  |  1.46e+01 +/- 7.6e-01  |

[ddudt]

It's fine for this PR because I would have approved it, but remember that in general our unofficial policy is to get 2 approvals before merging. More eyes help catch things that one person misses.

[YigitElma]

It's fine for this PR because I would have approved it, but remember that in general our unofficial policy is to get 2 approvals before merging. More eyes help catch things that one person misses.

Oh sorry, I thought one approval is fine in general. Also we have already talked about this during meeting, that's why I just merged it in.