-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some plot issues when NFP differs from one for objects, or when passed-in phi exceeds 2pi/nfp #1204
Merged
Merged
Fix some plot issues when NFP differs from one for objects, or when passed-in phi exceeds 2pi/nfp #1204
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
30fa4e7
fix some plot issues when NFP differs from one for objects, or when p…
dpanici 8df3025
finish comment
dpanici 184df17
add fix for plot_boundary and plot_section as well
dpanici 99d0e5e
add fix to plot_boundaries
dpanici 416444b
add missing note to docstring
dpanici cceb47b
Merge branch 'master' into dp/nfp-plot-err
dpanici a9215f3
Merge branch 'master' into dp/nfp-plot-err
dpanici b7f343d
Merge branch 'master' into dp/nfp-plot-err
dpanici 7b6b5a3
simplify fix
dpanici 55901f5
Merge branch 'master' into dp/nfp-plot-err
YigitElma 6a394bb
Merge branch 'master' into dp/nfp-plot-err
YigitElma daa8fd2
Merge branch 'master' into dp/nfp-plot-err
dpanici 0412130
update error message
dpanici 2c8f8a7
Merge branch 'master' into dp/nfp-plot-err
dpanici 3223d50
Merge branch 'master' into dp/nfp-plot-err
f0uriest File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dpanici Maybe we should change this to
Because integer
phi
is still ambigious.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, what does it do rn if phi integral is passed in? btw 0->2pi or 0->NFP of the first thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It uses 0 to 2pi/nfp of the last thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, doesn't throw any error or warning.