-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix _print_value_fmt
for some objectives and fix some latex labels
#1230
Conversation
_print_value_fmt
for some objectives
Can you also fix |
Are these all the objectives in the current master where the formatting specification is used after _print_value_fmt? |
I searched |
What is this exactly? You can add your commit here if it is a quick fix |
_print_value_fmt
for some objectives_print_value_fmt
for some objectives and fix some latex labels
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1230 +/- ##
==========================================
- Coverage 95.33% 95.33% -0.01%
==========================================
Files 90 90
Lines 22702 22702
==========================================
- Hits 21644 21642 -2
- Misses 1058 1060 +2
|
| benchmark_name | dt(%) | dt(s) | t_new(s) | t_old(s) |
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
test_build_transform_fft_lowres | -2.26 +/- 7.79 | -1.18e-02 +/- 4.07e-02 | 5.10e-01 +/- 3.5e-02 | 5.22e-01 +/- 2.0e-02 |
test_build_transform_fft_midres | -1.40 +/- 3.01 | -8.47e-03 +/- 1.82e-02 | 5.96e-01 +/- 5.9e-03 | 6.04e-01 +/- 1.7e-02 |
test_build_transform_fft_highres | -1.15 +/- 1.81 | -1.14e-02 +/- 1.80e-02 | 9.82e-01 +/- 6.8e-03 | 9.94e-01 +/- 1.7e-02 |
test_equilibrium_init_lowres | -1.59 +/- 1.27 | -6.05e-02 +/- 4.83e-02 | 3.74e+00 +/- 2.0e-02 | 3.80e+00 +/- 4.4e-02 |
test_equilibrium_init_medres | -4.02 +/- 3.46 | -1.70e-01 +/- 1.47e-01 | 4.06e+00 +/- 3.3e-02 | 4.23e+00 +/- 1.4e-01 |
test_equilibrium_init_highres | -1.15 +/- 1.44 | -6.25e-02 +/- 7.83e-02 | 5.39e+00 +/- 2.9e-02 | 5.45e+00 +/- 7.3e-02 |
test_objective_compile_dshape_current | +0.63 +/- 0.85 | +2.41e-02 +/- 3.22e-02 | 3.83e+00 +/- 3.1e-02 | 3.81e+00 +/- 7.8e-03 |
test_objective_compile_atf | -0.44 +/- 2.53 | -3.44e-02 +/- 1.99e-01 | 7.84e+00 +/- 1.4e-01 | 7.87e+00 +/- 1.4e-01 |
test_objective_compute_dshape_current | -0.72 +/- 2.09 | -2.53e-05 +/- 7.30e-05 | 3.47e-03 +/- 4.6e-05 | 3.49e-03 +/- 5.6e-05 |
test_objective_compute_atf | +4.42 +/- 4.07 | +4.54e-04 +/- 4.18e-04 | 1.07e-02 +/- 4.0e-04 | 1.03e-02 +/- 1.2e-04 |
test_objective_jac_dshape_current | +1.52 +/- 6.02 | +6.29e-04 +/- 2.49e-03 | 4.20e-02 +/- 1.6e-03 | 4.13e-02 +/- 1.9e-03 |
test_objective_jac_atf | +4.25 +/- 3.24 | +8.45e-02 +/- 6.46e-02 | 2.08e+00 +/- 4.6e-02 | 1.99e+00 +/- 4.5e-02 |
test_perturb_1 | +2.78 +/- 3.71 | +3.39e-01 +/- 4.51e-01 | 1.25e+01 +/- 4.5e-01 | 1.22e+01 +/- 6.3e-02 |
test_perturb_2 | +6.42 +/- 2.55 | +1.09e+00 +/- 4.35e-01 | 1.81e+01 +/- 3.6e-01 | 1.70e+01 +/- 2.5e-01 |
test_proximal_jac_atf | +1.97 +/- 4.32 | +1.63e-01 +/- 3.57e-01 | 8.44e+00 +/- 3.5e-01 | 8.28e+00 +/- 6.4e-02 |
test_proximal_freeb_compute | -0.67 +/- 0.97 | -1.23e-03 +/- 1.78e-03 | 1.82e-01 +/- 1.6e-03 | 1.83e-01 +/- 6.9e-04 |
test_proximal_freeb_jac | +1.23 +/- 1.65 | +9.14e-02 +/- 1.23e-01 | 7.55e+00 +/- 1.2e-01 | 7.46e+00 +/- 4.0e-02 |
test_solve_fixed_iter | +2.21 +/- 63.81 | +1.12e-01 +/- 3.23e+00 | 5.18e+00 +/- 2.5e+00 | 5.07e+00 +/- 2.1e+00 | |
#1189 changed the format of
_print_value_fmt
some recent merged PR's added new objectives that shouldn't work with the new format and throwIndexError: Replacement index 2 out of range for positional args tuple
.Also, I think I missed one of the objectives during that PR. This fixes the formats.
And some small label fixes.