Updated Legends to appear on ax instead of fig

[missing-user]

Resolves #1271 "Legends should appear on the ax object when passed to plotting functions"
Resolves #1280 "Plotting Unit Test Regression"

• Changed default legend positioning from fig to ax, to better support using DESC functions in subplots
• Passing an array of phi values to plot_boundaries plots cross-sections for each phi value, instead of skipping the last one.
• Reduced tolerances for plotting unit tests
• Updated plotting baseline

[YigitElma]

Thanks you for your help @missing-user !

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.45%. Comparing base (056fcc4) to head (3e1bd18).
Report is 23 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1272      +/-   ##
==========================================
+ Coverage   95.43%   95.45%   +0.01%     
==========================================
  Files          96       96              
  Lines       23791    23791              
==========================================
+ Hits        22706    22709       +3     
+ Misses       1085     1082       -3     

Files with missing lines	Coverage Δ
desc/plotting.py	96.18% <100.00%> (+0.07%)	⬆️

... and 1 file with indirect coverage changes

[f0uriest]

Tests pass locally for me with reduced tolerances. Would be good if a few other people can check as well, we've had issues in the past where if the tolerances are too tight we get a lot of false positives just due to hardware differences.

[YigitElma]

Tests also pass for me but I think I have the same hardware as @f0uriest . Can @dpanici or @kianorr tests this on Mac?

[YigitElma]

And please don't mind the benchmark action, our current CI doesn't allow PRs from forks to add automatic comments (which benchmark does at the end)

[YigitElma]

Resolve issue #1271 "Legends should appear on the ax object when passed to plotting functions"

Can you change the description to include "Resolves #1280" ?

[missing-user]

Sorry, thought you meant the title for a second... I think everything is ready to merge now, thanks for the help!

[dpanici]

works fine for me as well

[YigitElma]

@missing-user Thanks for the contribution!