Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cMAB Fast Update via Variational Inference #48

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

shaharbar1
Copy link
Collaborator

Changes

  • Edited BaseBayesianLogisticRegression and inheritors on model.py to support variational inference by adding fast_inference control parameter on class attributes and adding control arguments on update method.
  • Edited update UTs on test_cmab.py to support new inference mode.
  • Edited cMABs cold start function tto support new inference mode.
  • Removed redundant test_execution_time.py.
  • Edited version on pyproject.toml.

@shaharbar1 shaharbar1 force-pushed the feature/variational_infernce_cmab branch from 52719f8 to a7ad3ac Compare September 3, 2024 12:24
pybandits/cmab.py Outdated Show resolved Hide resolved
pybandits/cmab.py Outdated Show resolved Hide resolved
pybandits/model.py Outdated Show resolved Hide resolved
@shaharbar1 shaharbar1 force-pushed the feature/variational_infernce_cmab branch 7 times, most recently from e2e11ee to f6ffd58 Compare September 4, 2024 11:52
@shaharbar1 shaharbar1 added the enhancement New feature or request label Sep 4, 2024
@shaharbar1 shaharbar1 force-pushed the feature/variational_infernce_cmab branch 2 times, most recently from bdf207e to 5fc5a94 Compare September 23, 2024 08:50
pybandits/cmab.py Outdated Show resolved Hide resolved
pybandits/model.py Outdated Show resolved Hide resolved
@shaharbar1 shaharbar1 force-pushed the feature/variational_infernce_cmab branch 12 times, most recently from fb54f15 to 35b7da0 Compare September 23, 2024 12:25
pybandits/model.py Outdated Show resolved Hide resolved
pybandits/model.py Outdated Show resolved Hide resolved
pybandits/model.py Outdated Show resolved Hide resolved
pybandits/model.py Outdated Show resolved Hide resolved
pybandits/model.py Outdated Show resolved Hide resolved
pybandits/model.py Outdated Show resolved Hide resolved
 ### Changes
 * Edited BaseBayesianLogisticRegression and inheritors on model.py to support variational inference by adding fast_inference control parameter on class attributes and adding control arguments on update method.
 * Edited BaseBayesianLogisticRegression to allow faster update via vectorization of PyMC operations.
 * Edited "update" UTs on test_cmab.py to support new inference mode.
 * Edited cMABs cold start function tto support new inference mode.
 * Removed redundant test_execution_time.py.
 * Edited version on pyproject.toml.
@shaharbar1 shaharbar1 force-pushed the feature/variational_infernce_cmab branch from 35b7da0 to 6f3471e Compare September 23, 2024 14:03
@shaharbar1 shaharbar1 enabled auto-merge (squash) September 23, 2024 14:09
Copy link
Collaborator

@dariodandrea dariodandrea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @shaharbar1 !

@shaharbar1 shaharbar1 merged commit dfaab15 into develop Sep 23, 2024
3 checks passed
@shaharbar1 shaharbar1 deleted the feature/variational_infernce_cmab branch September 23, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants