-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cMAB Fast Update via Variational Inference #48
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaharbar1
force-pushed
the
feature/variational_infernce_cmab
branch
from
September 3, 2024 12:24
52719f8
to
a7ad3ac
Compare
adarmiento
reviewed
Sep 3, 2024
shaharbar1
force-pushed
the
feature/variational_infernce_cmab
branch
7 times, most recently
from
September 4, 2024 11:52
e2e11ee
to
f6ffd58
Compare
shaharbar1
force-pushed
the
feature/variational_infernce_cmab
branch
2 times, most recently
from
September 23, 2024 08:50
bdf207e
to
5fc5a94
Compare
shaharbar1
force-pushed
the
feature/variational_infernce_cmab
branch
12 times, most recently
from
September 23, 2024 12:25
fb54f15
to
35b7da0
Compare
### Changes * Edited BaseBayesianLogisticRegression and inheritors on model.py to support variational inference by adding fast_inference control parameter on class attributes and adding control arguments on update method. * Edited BaseBayesianLogisticRegression to allow faster update via vectorization of PyMC operations. * Edited "update" UTs on test_cmab.py to support new inference mode. * Edited cMABs cold start function tto support new inference mode. * Removed redundant test_execution_time.py. * Edited version on pyproject.toml.
shaharbar1
force-pushed
the
feature/variational_infernce_cmab
branch
from
September 23, 2024 14:03
35b7da0
to
6f3471e
Compare
dariodandrea
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @shaharbar1 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes