Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility for multiple Pydantic versions #66

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

shaharbar1
Copy link
Collaborator

Changes:

  • Add pydantic_version_compact.py with get_major_pydantic_version function to handle version-specific logic.
  • Updated test cases to use pydantic_version_compact for version compatibility.
  • Adjusted error handling in tests to accommodate different Pydantic versions.
  • Refactored imports and added necessary logic to support both Pydantic v1 and v2.
  • Updated continuous integration and delivery workflows to test for both version of pydantic.

@shaharbar1 shaharbar1 added the enhancement New feature or request label Oct 20, 2024
@shaharbar1 shaharbar1 force-pushed the feature/free_pydantic_compatibility branch 5 times, most recently from e6fb063 to 0b2cf46 Compare October 20, 2024 12:06
pybandits/base.py Outdated Show resolved Hide resolved
 ### Changes:
 * Add pydantic_version_compact.py with `get_major_pydantic_version` function to handle version-specific logic.
 * Updated test cases to use `pydantic_version_compatibility` for version compatibility.
 * Adjusted error handling in tests to accommodate different Pydantic versions.
 * Refactored imports and added necessary logic to support both Pydantic v1 and v2.
 * Updated continuous integration and delivery workflows to test for both version of pydantic.
@shaharbar1 shaharbar1 force-pushed the feature/free_pydantic_compatibility branch from 0b2cf46 to aae12b4 Compare October 21, 2024 06:54
@shaharbar1 shaharbar1 merged commit 8594158 into develop Oct 21, 2024
7 checks passed
@shaharbar1 shaharbar1 deleted the feature/free_pydantic_compatibility branch October 21, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants