Refactor SpinifyImpl to handle missing subscriptions in SpinifySubscr…

…iptionMixin
PlugFox · Jun 13, 2024 · c34dfe0 · c34dfe0
1 parent 9e122d8
commit c34dfe0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/lib/src/subscription_impl.dart b/lib/src/subscription_impl.dart
@@ -190,14 +190,18 @@ final class SpinifyClientSubscriptionImpl extends SpinifySubscriptionBase
   @override
   Future<void> subscribe() {
     throw UnimplementedError();
+    // TODO(plugfox): implement subscribe, add resubscribe timer
   }
 
   @override
   Future<void> unsubscribe([
     int code = 0,
     String reason = 'unsubscribe called',
-  ]) {
+  ]) async {
+    if (_state.isUnsubscribed) return Future.value();
+    //await ready().timeout(_client.config.timeout);
     throw UnimplementedError();
+    // TODO(plugfox): implement unsubscribe, remove resubscribe timer
   }
 }
 

diff --git a/lib/src/subscription_interface.dart b/lib/src/subscription_interface.dart
@@ -143,10 +143,10 @@ abstract interface class SpinifyClientSubscription
   /// Subscription configuration.
   abstract final SpinifySubscriptionConfig config;
 
-  /// Start subscribing to a channel
+  /// Start subscribing to a channel interactively.
   Future<void> subscribe();
 
-  /// Unsubscribe from a channel
+  /// Unsubscribe from a channel interactively.
   Future<void> unsubscribe([
     int code = 0,
     String reason = 'unsubscribe called',