-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code coverage #9
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new step in the checkout workflow to verify the versions of the project. It compares the version specified in the `pubspec.yaml` file with the version generated in the `pubspec.yaml.g.dart` file. If the versions match, it prints a success message. If the versions don't match, it prints an error message and exits with a non-zero status code.
This commit updates the `checkout.yml` workflow file to improve the version verification step. It modifies the commands to extract the version numbers from the `pubspec.yaml` and `pubspec.yaml.g.dart` files using the `grep` and `awk` commands. Additionally, it uses the `sed` command to remove any non-printable characters from the extracted version numbers. This ensures that the comparison between the two versions is accurate. The updated workflow now prints the version numbers and exits with a non-zero status code if they don't match.
This commit simplifies the `add` method in the `SpinifyLogBuffer` class. It removes unnecessary conditional statements and reduces the number of lines of code. The logic for updating the buffer length and index has been condensed into a single line. This change improves the readability and maintainability of the code.
This commit simplifies the `logger` method in the `smoke_test.dart` file. It removes the unnecessary `loggerPrint` function and consolidates the logic into a single `logger` function. The `enablePrint` flag is now used to control whether the log messages are printed or not. Additionally, the `logBuffer` is now initialized with a size of 100. These changes improve the readability and maintainability of the code.
This commit adds the functionality for message publication and subscription to the `smoke_test.dart` file. It introduces a list of messages to be published and verifies that the messages are received in the correct order. This enhancement improves the testing capabilities of the code.
This commit updates the code coverage configuration in the Makefile. It modifies the coverage command to include both the unit_test.dart and smoke_test.dart files. Additionally, it adjusts the lcov filtering to exclude specific files. These changes improve the accuracy and completeness of the code coverage report.
…B$VM This commit updates the lcov filtering in the Makefile and SpinifyTransport$WS$PB$VM files. It modifies the lcov command in the Makefile to exclude specific files related to protobuf and client code. In the SpinifyTransport$WS$PB$VM file, it adds coverage ignore comments to certain code blocks. These changes improve the accuracy of the code coverage report and ensure that the correct files are included/excluded.
This commit updates the lcov filtering in the Makefile and SpinifyTransport$WS$PB$VM files. It modifies the lcov command in the Makefile to exclude specific files related to protobuf and client code. In the SpinifyTransport$WS$PB$VM file, it adds coverage ignore comments to certain code blocks. Additionally, it adds a new step to check the code coverage and ensure it meets the threshold of 50%. These changes improve the accuracy of the code coverage report and ensure that the correct files are included/excluded.
This commit updates the PORT environment variable in the tests.yml file. It changes the value from 8080 to 8000 to align with the updated configuration. This modification ensures that the tests run on the correct port and reflects the recent changes made to the codebase.
This commit updates the echo server build process in the tests.yml file. It modifies the command to redirect the server logs to a separate file called echo.log. Additionally, it saves the process ID of the echo server to echo_pid.txt for later use. This change improves the logging and ensures better management of the echo server process.
This commit updates the tests.yml file to install lcov and check the code coverage. It adds a new step to install lcov and jq dependencies using apt-get. It also modifies the check-coverage step to generate lcov.info, filter out specific files, and calculate the code coverage percentage. The threshold is set to 50%, and if the coverage is below the threshold, the step will exit with an error. This change improves the accuracy of the code coverage report and ensures that the correct files are included/excluded.
This commit modifies the tests.yml file to download and cache the Go echo server artifact. It removes the previous step that uploaded the echo server artifact and replaces it with a new step that downloads and restores the cached artifact using the actions/cache/restore action. This change improves the efficiency of the workflow by avoiding unnecessary artifact uploads and ensures consistent usage of the echo server across different workflow runs.
…ge check This commit modifies the tests.yml file to remove the lcov filtering step and update the coverage check. It replaces the previous lcov command with a new one that includes all files in the coverage report. Additionally, it updates the coverage check step to calculate the coverage percentage based on the lcov.info file. This change simplifies the workflow and ensures accurate code coverage measurement.
…iable This commit modifies the tests.yml file to include the threshold as an environment variable. It adds a new line to set the threshold value to 50. This change allows for easier customization of the coverage threshold without modifying the workflow file directly.
This commit modifies the tests.yml file to include the coverage percentage in the logs. It adds a new line to echo the coverage percentage after calculating it from the lcov.info file. This change provides visibility into the coverage results during the workflow execution.
This commit fixes the coverage calculation in the tests.yml file. The previous command used to extract the coverage percentage was incorrect, resulting in inaccurate coverage results. This change updates the command to correctly extract the coverage percentage from the lcov.info file, ensuring accurate reporting of code coverage during the workflow execution.
This commit updates the dependabot.yaml file to fix the timezone value in the schedule section. The previous value was set to "UTC", but it has been changed to "Etc/GMT" to accurately reflect the desired timezone. This change ensures that the schedule runs at the correct time according to the specified timezone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.