Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKEND] Extend authorized PostgreSQL database URI #2952

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

jacquesfize
Copy link
Contributor

@jacquesfize jacquesfize commented Mar 8, 2024

@jacquesfize jacquesfize self-assigned this Mar 8, 2024
@jacquesfize jacquesfize added this to the 2.14.1 milestone Mar 8, 2024
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.44%. Comparing base (6bc950c) to head (98c4583).
Report is 9 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2952   +/-   ##
========================================
  Coverage    78.44%   78.44%           
========================================
  Files           89       89           
  Lines         7199     7199           
========================================
  Hits          5647     5647           
  Misses        1552     1552           
Flag Coverage Δ
pytest 78.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheoLechemia
Copy link
Member

Je sais pas si ça vaut le coup de les supporter, mais cette URI (fourni dans les exemple de PG) : postgresql://host1:123,host2:456/somedb?target_session_attrs=any&application_name=myapp
ne passe pas la validation.
Pour les services, niquel

@jacquesfize
Copy link
Contributor Author

jacquesfize commented Mar 11, 2024

Le problème vient de sqlalchemy qui ne prend pas encore en compte ce genre d'URL :/ sqlalchemy/sqlalchemy#4392

@jacquesfize jacquesfize merged commit 16b4eca into develop Mar 14, 2024
9 checks passed
@jacquesfize jacquesfize deleted the feat/extend_psql_authorized_uri branch March 14, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants