-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINTENANCE] Change path and remove branch name in .gitmodules
#2959
Conversation
.gitmodules
+ remove branch name
.gitmodules
+ remove branch name.gitmodules
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2959 +/- ##
========================================
Coverage 78.44% 78.44%
========================================
Files 89 89
Lines 7199 7199
========================================
Hits 5647 5647
Misses 1552 1552
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
41d96d5
to
9e09357
Compare
Avis personnelIl me semble cohérent que les URL des submodules soient systématiquement définies avec le même protocole : HTTPS, SSH Git... ; que pour les URL du remote du dépôt parent. Par exemple, si on fait pointer son dépôt Reste à faireSi validé, faire de même pour les autres dépôts : InformationsPour Pour Il me semble qu'il y avait également une PR ou une issue pour permettre de configurer l'utilisation du protocole HTTPS ou bien du protocole SSH Git dès l'installation d'une instance GeoNature, mais je n'en retrouve plus la trace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testé pour les 2 protocoles HTTPS ; https://github.com/PnX-SI/GeoNature.git
; et SSH ; git@github.com:PnX-SI/GeoNature.git
; et approuvé.
Tests effectués :
git clone -b feat/gitmodule_relative_path --single-branch https://github.com/PnX-SI/GeoNature.git` geonature_git_https
cd geonature_git_https
git submodule init
git submodule update
cd backend/dependencies/RefGeo
git remote -v
git clone -b feat/gitmodule_relative_path --single-branch git@github.com:PnX-SI/GeoNature.git geonature_git_ssh`
cd geonature_git_ssh
git submodule init
git submodule update
cd backend/dependencies/RefGeo
git remote -v
In the .gitmodules file, url given for each submodule can be indicated using relative URL to the parent (here GeoNature git url). It allows to clone both GeoNature and its submodule using the same method (HTTPS or SSH).