Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add gitignore to custom folder instead of gitkeep #3181

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

ch-cbna
Copy link
Contributor

@ch-cbna ch-cbna commented Sep 12, 2024

See #3179

@jacquesfize
Copy link
Contributor

Pas chaud de refaire un gitignore... (normalement) Il est possible de faire ça dans le .gitignore principale (voir #3179 (comment))

Copy link
Contributor

@jpm-cbna jpm-cbna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il faudrait fusionner les différents commits de la branche pour faciliter la fusion.

.gitignore Show resolved Hide resolved
fix(custom): restore gitkeep and add it to GN gitignore

chore: add 'environ' file to gitignore
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.62%. Comparing base (3c2f64f) to head (64ad93f).
Report is 227 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3181      +/-   ##
===========================================
+ Coverage    78.50%   81.62%   +3.11%     
===========================================
  Files           89       86       -3     
  Lines         7208     6945     -263     
===========================================
+ Hits          5659     5669      +10     
+ Misses        1549     1276     -273     
Flag Coverage Δ
pytest 81.62% <ø> (+3.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jpm-cbna jpm-cbna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok pour moi.

@jacquesfize jacquesfize merged commit c3f7f65 into PnX-SI:develop Sep 30, 2024
7 checks passed
@jacquesfize jacquesfize added this to the 2.15 milestone Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants