-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): move to GitHub actions #678
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5e58d35
to
95f0433
Compare
95f0433
to
cbf54ec
Compare
7ac49ab
to
9a4ca8a
Compare
48f2a5b
to
5056e79
Compare
162ba1d
to
7143982
Compare
7143982
to
f1f25e8
Compare
628c46a
to
e69a306
Compare
8ebfcf3
to
a74687c
Compare
a74687c
to
005d653
Compare
005d653
to
61cd110
Compare
🎉 This issue has been resolved in version @pocket-tools/terraform-modules-v5.12.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
account-data-deleter-cdk-production/add-or-update
annotations-api-cdk-development/add-or-update
annotations-api-cdk-production/add-or-update
client-api-cdk-development/add-or-update
client-api-cdk-production/add-or-update
feature-flags-cdk-production/add-or-update
image-api-cdk-production/add-or-update
list-api-cdk-production/add-or-update
released
shareable-lists-api-cdk-development/add-or-update
shareable-lists-api-cdk-production/add-or-update
shares-api-cdk-development/add-or-update
shares-api-cdk-production/add-or-update
user-api-cdk-production/add-or-update
user-list-search-production/add-or-update
v3-proxy-api-cdk-production/destroy
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The way we currently use CircleCI with self-hosted runners has been a "hack" and is no longer going to be supported come this september.
Instead of mitigating within CircleCI we are going to move away from CircleCI in favor of github actions to align more closely with the rest of Mozilla and allow us to eventually shut down a service bill.
Details
This PR relies on us using OIDC AWS based auth to perform our terraform actions within our AWS account. This allows us to assume roles from our github organization within Github Actions.
This ensures that github only gets short lived tokens into our AWS account and that it is always rotating.